[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

salman-javed-nz added a comment. In D116378#3226780 , @carlosgalvezp wrote: > By the way, the similar problem exists in Clang compiler. I have written in > cfe-dev , > Discourse >

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

carlosgalvezp added a comment. In D116378#3226242 , @salman-javed-nz wrote: > This resolves the long-standing gripe I have with clang-tidy raising warnings > about GoogleTest macros expanded in my code. Good work. > Do you think we can close issues #448

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

salman-javed-nz added a comment. This resolves the long-standing gripe I have with clang-tidy raising warnings about GoogleTest macros expanded in my code. Good work. Do you think we can close issues #44873 , #43325

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG670de10f9dea: Disable clang-tidy warnings from system macros (authored by carlosgalvezp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

carlosgalvezp added a comment. Thanks for the review! I've fixed the nit, reverted unrelated changes to backticks and moved the class to the existing anonymous namespace. Since those are NFC changes I'll push now, if you don't agree let me know and I'll revert right away :)

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

carlosgalvezp updated this revision to Diff 397958. carlosgalvezp added a comment. - Refactor duplicated warning message into a common variable. - Remove double backticks change, TBH I get conflicting review comments about this and can't find any docs supporting either, so I'll just keep it consi

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. LGTM aside from a minor nit, thanks! This was a good catch. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:32-33 + Chec

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:23-40 +namespace { +class VaArgPPCallbacks : public PPCallbacks { +public: + VaArgPPCallbacks(ProTypeVarargCheck *Check) : Check(Check) {} + + void MacroExpan

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

carlosgalvezp updated this revision to Diff 397859. carlosgalvezp added a comment. Revert formatting, clarify necessary changes to existing check in the commit message. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116378/new/ https://reviews.llvm.org/D116378 Files: clang-tools-extr

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

carlosgalvezp added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:23-40 +namespace { +class VaArgPPCallbacks : public PPCallbacks { +public: + VaArgPPCallbacks(ProTypeVarargCheck *Check) : Check(Check) {} + + void MacroExpan

[PATCH] D116378: [clang-tidy] Disable clang-tidy warnings from system macros

salman-javed-nz added inline comments. Comment at: clang-tools-extra/clang-tidy/cppcoreguidelines/ProTypeVarargCheck.cpp:23-40 +namespace { +class VaArgPPCallbacks : public PPCallbacks { +public: + VaArgPPCallbacks(ProTypeVarargCheck *Check) : Check(Check) {} + + void MacroExp