[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. ymandel marked an inline comment as done. Closed by commit rG4dcc47aaeaf0: [clang][dataflow] Add parameterized map lattice. (authored by ymandel). Repository: rG LLV

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MapLattice.h:92 + /// entry as it was in the source map. + LatticeJoinEffect join(const MapLattice &Other) { +LatticeJoinEffect Effect = LatticeJo

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

xazax.hun accepted this revision. xazax.hun added inline comments. This revision is now accepted and ready to land. Comment at: clang/include/clang/Analysis/FlowSensitive/MapLattice.h:92 + /// entry as it was in the source map. + LatticeJoinEffect join(const MapLattice &Other)

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

ymandel marked an inline comment as done. ymandel added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MapLattice.h:92 + /// entry as it was in the source map. + LatticeJoinEffect join(const MapLattice &Other) { +LatticeJoinEffect Effect = LatticeJo

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

xazax.hun added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/MapLattice.h:92 + /// entry as it was in the source map. + LatticeJoinEffect join(const MapLattice &Other) { +LatticeJoinEffect Effect = LatticeJoinEffect::Unchanged; It

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

ymandel marked 3 inline comments as done. ymandel added a comment. In D116369#3212532 , @sgatev wrote: > It seems unnecessary to deal with AST elements in the tests for `MapLattice`. > I think testing it with integer or string keys would be simpler. Give

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

ymandel updated this revision to Diff 396570. ymandel marked 2 inline comments as done. ymandel added a comment. update comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116369/new/ https://reviews.llvm.org/D116369 Files: clang/include/clan

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

ymandel updated this revision to Diff 396565. ymandel added a comment. addressed comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116369/new/ https://reviews.llvm.org/D116369 Files: clang/include/clang/Analysis/FlowSensitive/MapLattice.h

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

sgatev added a comment. It seems unnecessary to deal with AST elements in the tests for `MapLattice`. I think testing it with integer or string keys would be simpler. Given that `VarMapLattice` is just an alias, I don't think it's necessary to add dedicated tests for it. What do you think? =

[PATCH] D116369: [clang][dataflow] Add parameterized map lattice.

ymandel created this revision. ymandel added reviewers: xazax.hun, gribozavr2, sgatev. Herald added subscribers: rnkovacs, mgorny. ymandel requested review of this revision. Herald added a project: clang. This patchs adds a `MapLattice` template for lifting a lattice to a keyed map. A typical use