[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGaf7bc39ba17d: [clang][dataflow] Add transfer function for VarDecl statements (authored by sgatev). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev marked 3 inline comments as done. sgatev added a comment. Thanks for the reviews! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 ___ cfe-commits mailing

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

xazax.hun added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:88 +for (const FieldDecl *Field : Type->getAsRecordDecl()->fields()) { + FieldLocs.insert({Field, &createStorageLocation(Field->getType())}); +} sga

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev marked 4 inline comments as done. sgatev added inline comments. Comment at: clang/lib/Analysis/FlowSensitive/DataflowEnvironment.cpp:32 +template +bool denseMapsAreEqual(const llvm::DenseMap &Map1, + const llvm::DenseMap &Map2) { xaz

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev updated this revision to Diff 396778. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 Files: clang/include/clang/Analysis/FlowSensitive/Datafl

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. I have one nit inline, and some topics that should probably be deferred to follow-up PRs. Overall, looks good to me, thanks! Comment at: clang/include/clang/Analysis/

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev updated this revision to Diff 396668. sgatev added a comment. Canonicalize types. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 Files: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysi

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:61 + /// `D` must not be assigned a storage location. + void setStorageLocation(const VarDecl &D, StorageLocation &Loc) { +assert(VarDeclToLoc.find(&D) == VarDec

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev updated this revision to Diff 396660. sgatev marked 12 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 Files: clang/i

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

xazax.hun added a comment. Thanks! I have some questions inline. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:61 + /// `D` must not be assigned a storage location. + void setStorageLocation(const VarDecl &D, StorageLocation &Loc) { +a

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev updated this revision to Diff 396537. sgatev added a comment. Convert pointers to references. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 Files: clang/include/clang/Analysis/FlowSensitive/Dat

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev added inline comments. Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:56 + + /// Assigns `Loc` to `D`. + /// ymandel wrote: > The term "assignment" is overloaded. :) Maybe instead "Associates `Loc` with > `D`"? Or, exp

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev updated this revision to Diff 396529. sgatev marked 8 inline comments as done. sgatev added a comment. Address reviewers' comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 Files: clang/in

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

ymandel added a comment. Nice! A few small comments on the headers... Comment at: clang/include/clang/Analysis/FlowSensitive/DataflowAnalysisContext.h:56 + + /// Assigns `Loc` to `D`. + /// The term "assignment" is overloaded. :) Maybe instead "Associates `

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev updated this revision to Diff 396516. sgatev added a comment. Minor changes to names and comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116368/new/ https://reviews.llvm.org/D116368 Files: clang/include/clang/Analysis/FlowSensitiv

[PATCH] D116368: [clang][dataflow] Add transfer function for VarDecl statements

sgatev created this revision. sgatev added reviewers: ymandel, xazax.hun, gribozavr2. Herald added subscribers: rnkovacs, mgorny. sgatev requested review of this revision. Herald added a project: clang. This is part of the implementation of the dataflow analysis framework. See "[RFC] A dataflow an