This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcd45e8c7bc16: [CodeCompletion] Signature help for template
argument lists (authored by sammccall).
Changed prior to commit:
https://reviews.llvm.o
kadircet accepted this revision.
kadircet added a comment.
thanks! as discussed offline i think it's better to ignore function parameters
for now.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3781
+// If the template is for a function `bool foo(int)`, then returns
+// `bool
sammccall updated this revision to Diff 397049.
sammccall added a comment.
Change ResultType handling for template functions. Given:
template string getName(int count) const &
We return the signature:
{ResultType=string} getName<{placeholder=typename T}>()
Clangd renders this as:
getNa
sammccall added inline comments.
Comment at: clang/lib/Sema/SemaCodeComplete.cpp:3785
+ if (const auto *FTD = dyn_cast(TD))
+return FTD->getTemplatedDecl()->getType().getAsString(Policy);
+ if (isa(TD))
kadircet wrote:
> the rendering looks a little bit sur
kadircet added a comment.
thanks this looks great! just a question around rendering of the result type
chunk. feel free to leave a fixme if there's no easy way of doing that.
Comment at: clang/lib/Parse/ParseTemplate.cpp:1237
+///
+/// \param NameHint is not required, and mere
sammccall updated this revision to Diff 396455.
sammccall added a comment.
Clean up style, remove fixed fixme, add an extra testcase.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116352/new/
https://reviews.llvm.org/D116352
Files:
clang-tools-e
sammccall created this revision.
sammccall added reviewers: kadircet, usaxena95.
Herald added a subscriber: arphaman.
sammccall requested review of this revision.
Herald added subscribers: cfe-commits, ilya-biryukov.
Herald added projects: clang, clang-tools-extra.
Provide signature while typing t
