[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

2022-01-03 Thread Sam McCall via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG92417eaf3329: [CodeCompletion] Signature help for braced constructor calls (authored by sammccall). Changed prior to commit: https://reviews.llvm.

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

2022-01-03 Thread Sam McCall via Phabricator via cfe-commits
sammccall added inline comments. Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:995 /// \param NumCandidates the number of overload candidates void ProcessOverloadCandidates(Sema &S, unsigned CurrentArg, O

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

2022-01-03 Thread Kadir Cetinkaya via Phabricator via cfe-commits
kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! Comment at: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp:995 /// \param NumCandidates the number of overload candidates void

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

2021-12-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 396362. sammccall added a comment. Fix clangd tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116317/new/ https://reviews.llvm.org/D116317 Files: clang-tools-extra/clangd/ClangdLSPServer.cpp clang-t

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

2021-12-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 396325. sammccall edited the summary of this revision. sammccall added a comment. Herald added subscribers: JDevlieghere, ilya-biryukov. Revert some unintended changes, clean up tests. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

2021-12-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall updated this revision to Diff 396324. sammccall added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix lldb build Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116317/new/ https://reviews.llvm.org/D116

[PATCH] D116317: [CodeCompletion] Signature help for braced constructor calls

2021-12-27 Thread Sam McCall via Phabricator via cfe-commits
sammccall created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added projects: clang, clang-tools-extra. Herald added a subscriber: cfe-commits. Implementation is based on the "expected type" as used for designated-init