[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGccebf8ac8c61: [Clang][OpenMP] Add support for compare capture in parser (authored by tianshilei1992). Repository: rG LLVM Github Monorepo CHANGES

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 ___

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 409791. tianshilei1992 added a comment. add a small test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/li

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added a comment. In D116261#3330732 , @tianshilei1992 wrote: > We don't have Sema yet, so there is no erroneous test. But you have the checks for the clauses, repeated several times in a construct. Repository: rG LLVM Github Monorepo CHANGE

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 added a comment. We don't have Sema yet, so there is no erroneous test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 ___ cfe-commits mailing l

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added a comment. Erroneous tests? Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { tianshilei1992 wrote: > ABataev wrote: > > ABatae

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 408226. tianshilei1992 marked an inline comment as done. tianshilei1992 added a comment. add tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: cla

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { ABatae

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { ABataev wrote: > tianshilei1992 wrote: > > ABataev wrote: > >

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { tianshilei1992 wrote: > ABataev wrote: > > tianshilei1992 wrot

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { ABatae

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { tianshilei1992 wrote: > ABataev wrote: > > tianshilei1992 wrot

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { ABatae

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { tianshilei1992 wrote: > ABataev wrote: > > SmallVector with 2

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { ABatae

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added a comment. Add ast print with serialization/deserialization tests. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11320 + bool MutexClauseEncountered = false; + llvm::SmallSet EncounteredAtomicKinds; for (const OMPClause *C : Clauses) { SmallVecto

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11790-11797 +if (IsCompareCapture) { + // TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore + // code gen. + un

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11790-11797 +if (IsCompareCapture) { + // TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore + // code gen. + unsigned DiagID = Diags.getCustomDiagID( + Diagno

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407868. tianshilei1992 added a comment. fix errors Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp clang/lib/Sema

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11801-11807 + } else if (AtomicKind == OMPC_compare_capture) { +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +//

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407701. tianshilei1992 added a comment. remove the dummy node Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/lib/CodeGen/CGStmtOpenMP.cpp cla

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11801-11807 + } else if (AtomicKind == OMPC_compare_capture) { +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +// code gen. +unsigned DiagID = Diags.getCustomDiagID(

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11801-11807 + } else if (AtomicKind == OMPC_compare_capture) { +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +//

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11801-11807 + } else if (AtomicKind == OMPC_compare_capture) { +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +// code gen. +unsigned DiagID = Diags.getCustomDiagID(

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked an inline comment as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11801-11807 + } else if (AtomicKind == OMPC_compare_capture) { +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +//

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11801-11807 + } else if (AtomicKind == OMPC_compare_capture) { +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +// code gen. +unsigned DiagID = Diags.getCustomDiagID(

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407312. tianshilei1992 added a comment. cleanup Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/include/clang/AST/OpenMPClause.h clang/include

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407309. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. use `LLVM_FALLTHROUGH` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 3 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} ABataev w

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 407307. tianshilei1992 marked 2 inline comments as done. tianshilei1992 added a comment. rebase and mark related functions as unreachable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https:/

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} tianshilei1992 wrote: > ABataev wrote: > > Output? > I did it on

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::VisitOMPCompareCaptureClause(OMPCompareCaptureClause *) { + // Do nothing as it is dummy. +} ABataev w

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2277 +/// clauses. +class OMPCompareCaptureClause : public OMPClause { +public: `final` Comment at: clang/lib/AST/OpenMPClause.cpp:1804 +void OMPClausePrinter::Vi

[PATCH] D116261: [Clang][OpenMP] Add support for compare capture in parser

tianshilei1992 updated this revision to Diff 406867. tianshilei1992 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116261/new/ https://reviews.llvm.org/D116261 Files: clang/include/clang/AST/OpenMPClause.h clang/include/