[PATCH] D116218: [clangd] Fix selection on multi-dimensional array.

This revision was automatically updated to reflect the committed changes. Closed by commit rG20f8f46c60b3: [clangd] Fix selection on multi-dimensional array. (authored by hokein). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116218/new/ https://rev

[PATCH] D116218: [clangd] Fix selection on multi-dimensional array.

hokein updated this revision to Diff 397233. hokein added a comment. refine the patch based on D116536 , and one more test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116218/new/ https://reviews.llvm.org/D11621

[PATCH] D116218: [clangd] Fix selection on multi-dimensional array.

hokein added inline comments. Comment at: clang-tools-extra/clangd/Selection.cpp:526 + // the traversal order of SizeExpr and ElementTypeLoc, which gives a chance + // for the SizeExpr to claim its tokens. + bool TraverseConstantArrayTypeLoc(ConstantArrayTypeLoc X) { -

[PATCH] D116218: [clangd] Fix selection on multi-dimensional array.

sammccall added a comment. Ooh, this is messy indeed. Thanks for digging! Comment at: clang-tools-extra/clangd/Selection.cpp:526 + // the traversal order of SizeExpr and ElementTypeLoc, which gives a chance + // for the SizeExpr to claim its tokens. + bool TraverseConstantAr

[PATCH] D116218: [clangd] Fix selection on multi-dimensional array.

hokein created this revision. hokein added a reviewer: sammccall. Herald added subscribers: usaxena95, kadircet, arphaman. hokein requested review of this revision. Herald added subscribers: MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. Repository: rG LLVM Github Monorepo h