[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG85c2bd2a0e0e: Prevent adding module flag amdgpu_hostcall multiple

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien added a comment. In D116216#3251066 , @yaxunl wrote: > LGTM. Thanks. Could you please commit on my behalf? I don't have a commit access to llvm trunk CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

yaxunl accepted this revision. yaxunl added a comment. LGTM. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien updated this revision to Diff 400750. pvellien added a comment. Removed amdgpu-asan-noprintf.cu and added amdgpu-asan-printf.cu testcase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 Files: clang/lib/CodeGen/CodeGenModule.cpp c

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

yaxunl added a comment. I think it will be cleaner to keep the original amdgpu-asan.cu unchanged whereas add amdgpu-asan-printf.cu which tests asan with printf. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 _

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien updated this revision to Diff 398519. pvellien added a comment. Herald added subscribers: kerbowa, nhaehnle, jvesely. @lebedev.ri updated with test-cases. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 Files: clang/lib/CodeGen/Code

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

yaxunl added a comment. In D116216#3209335 , @pvellien wrote: > @yaxunl It would be very much helpful to know how to write test coverage for > this particular patch? thanks there is a lit test amdgpu-asan.cu. You can add a call of print to that test an

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien added a comment. @yaxunl It would be very much helpful to know how to write test coverage for this particular patch? thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 __

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

lebedev.ri added a comment. In D116216#3208096 , @pvellien wrote: > The testcases related to this patch are already added via this patch > https://reviews.llvm.org/D112820. If this patch does not result in test changes, then there is no test coverage.

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien added a comment. The testcases related to this patch are already added via this patch https://reviews.llvm.org/D112820. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 __

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

lebedev.ri requested changes to this revision. lebedev.ri added a comment. This revision now requires changes to proceed. test coverage? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 ___

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

yaxunl accepted this revision. yaxunl added a comment. This revision is now accepted and ready to land. LGTM. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116216/new/ https://reviews.llvm.org/D116216 __

[PATCH] D116216: Prevent adding module flag - amdgpu_hostcall multiple times.

pvellien created this revision. Herald added subscribers: t-tye, tpr, dstuttard, yaxunl, kzhuravl. pvellien requested review of this revision. Herald added subscribers: cfe-commits, wdng. Herald added a project: clang. HIP program with printf call fails to compile with -fsanitize=address option,