[PATCH] D116174: [clang] support relative roots to vfs overlays

This revision was automatically updated to reflect the committed changes. Closed by commit rG4f61749e16f6: [clang] support relative roots to vfs overlays (authored by rmaz, committed by ellis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 400983. rmaz added a comment. Rebase on stable commit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Inputs/vfsoverlay-root-relative.yaml clan

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 400894. rmaz added a comment. Windows test fixes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Inputs/vfsoverlay-root-relative.yaml clang/tes

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 400102. rmaz added a comment. Update VirtualFileSystemTest to validate relative root paths. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Input

[PATCH] D116174: [clang] support relative roots to vfs overlays

benlangmuir added a comment. Make sure the test failure gets fixed, but otherwise LGTM. > x64 debian > LLVM-Unit.Support/_/SupportTests::VFSFromYAMLTest.RelativePaths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.o

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 48. rmaz added a comment. Add comment to describe relative root path behaviour Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Inputs/vfsover

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz added a comment. In D116174#3242087 , @benlangmuir wrote: > Each VFS may have its own working directory, so it could be surprising if we > use the OS working directory instead of that. This is complicated by the > fact the VFS working directory m

[PATCH] D116174: [clang] support relative roots to vfs overlays

benlangmuir added a comment. Each VFS may have its own working directory, so it could be surprising if we use the OS working directory instead of that. This is complicated by the fact the VFS working directory may not be set yet during parsing the yaml (I haven't checked). I'm not really sure

[PATCH] D116174: [clang] support relative roots to vfs overlays

dexonsmith added subscribers: vsapsai, benlangmuir. dexonsmith added a comment. In D116174#3206895 , @keith wrote: > This LGTM but I'm interested to hear from folks with more knowledge about the > VFS' desired behavior to comment on if this will have any

[PATCH] D116174: [clang] support relative roots to vfs overlays

keith added a comment. This LGTM but I'm interested to hear from folks with more knowledge about the VFS' desired behavior to comment on if this will have any unexpected side effects Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 395896. rmaz added a comment. clang-format changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Inputs/vfsoverlay-root-relative.yaml clang/t

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz updated this revision to Diff 395893. rmaz added a comment. lint Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116174/new/ https://reviews.llvm.org/D116174 Files: clang/test/VFS/Inputs/vfsoverlay-root-relative.yaml clang/test/VFS/vfsoverl

[PATCH] D116174: [clang] support relative roots to vfs overlays

rmaz created this revision. Herald added subscribers: dexonsmith, hiraditya. rmaz requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This diff adds support for relative roots to VFS overlays. The directory root will be made a