[PATCH] D116170: [clang-format] Add penalty for breaking after '('

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcfe3180742ad: [clang-format] Add penalty for breaking after '(' (authored by G. Pery , committed by curdeius). Repository: rG LLVM Gi

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

GPery added a comment. In D116170#3217198 , @curdeius wrote: > @GPery, do you need help landing this? > If so, please indicate the name and email you'd like to be used for the > commit. Oh, sure, I didn't realise this part wasn't automatic. It's "gpery"

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

curdeius added a comment. @GPery, do you need help landing this? If so, please indicate the name and email you'd like to be used for the commit. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

curdeius accepted this revision. curdeius added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list cfe-commits@lists.

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

GPery added a comment. Fixed and marked :D Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

GPery updated this revision to Diff 396547. GPery marked 4 inline comments as done. GPery added a comment. Now using verifyFormat! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 Files: clang/docs/Clang

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

HazardyKnusperkeks added a comment. Looks good, use the `verifyFormat` and please mark comments as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18519 + Style.PenaltyExcessCharacter = 15; + EXPECT_EQ("int foo(\n" +"int );", any reason you are not using verifyFormat here? Repo

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

GPery updated this revision to Diff 396527. GPery added a comment. Resorted everything and added more tests, thanks for the comments <3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 Files: clang/docs/

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

HazardyKnusperkeks added inline comments. Comment at: clang/include/clang/Format/Format.h:2900 + /// \version 14 + unsigned PenaltyBreakOpenParenthesis; + Please resort. Comment at: clang/lib/Format/Format.cpp:1238 LLVMStyle.PenaltyBreakTe

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

MyDeveloperDay added inline comments. Comment at: clang/unittests/Format/FormatTest.cpp:18515 +TEST_F(FormatTest, BreakPenaltyAfterLParen) { + FormatStyle Style = getLLVMStyle(); 1) fix the formatting 2) add a default case which shows how the bracket will

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

GPery updated this revision to Diff 396317. GPery edited the summary of this revision. GPery added a comment. Add a unit test and initialisation in LLVMStyle Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

HazardyKnusperkeks added a comment. And initialize the value. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list cfe-commits@lists.llv

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

MyDeveloperDay added a comment. You need some unit tests to show it working. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116170/new/ https://reviews.llvm.org/D116170 ___ cfe-commits mailing list cfe-co

[PATCH] D116170: [clang-format] Add penalty for breaking after '('

GPery created this revision. GPery requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D116170 Files: clang/docs/ClangFormatStyleOptions.rst clang/include/clang/Format/Format.