[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

2022-01-04 Thread Jun Zhang via Phabricator via cfe-commits
junaire added a comment. In D116161#3219343 , @fhahn wrote: > In D116161#3219149 , @junaire wrote: > >> In D116161#3219080 , @fhahn wrote: >> >>> @junaire please let me kn

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

2022-01-04 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. In D116161#3219149 , @junaire wrote: > In D116161#3219080 , @fhahn wrote: > >> @junaire please let me know if you want me to land this on your behalf. > > Yeah, thanks a lot! > > You can use

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

2022-01-04 Thread Florian Hahn via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5c57e6aa5777: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic. (authored by junaire, committed by fhahn). Repository: rG LLVM Github Mono

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

2022-01-04 Thread Jun Zhang via Phabricator via cfe-commits
junaire added a comment. In D116161#3219080 , @fhahn wrote: > @junaire please let me know if you want me to land this on your behalf. Yeah, thanks a lot! You can use: Jun Zhang j...@junz.org Repository: rG LLVM Github Monorepo CHANGES SINCE LAST AC

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

2022-01-04 Thread Florian Hahn via Phabricator via cfe-commits
fhahn added a comment. @junaire please let me know if you want me to land this on your behalf. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161 ___ cfe-commits m

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

2022-01-02 Thread Florian Hahn via Phabricator via cfe-commits
fhahn accepted this revision. fhahn added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D116161

[PATCH] D116161: [Clang] Extend emitUnaryBuiltin to avoid duplicate logic.

2021-12-28 Thread Jun Zhang via Phabricator via cfe-commits
junaire updated this revision to Diff 396492. junaire edited the summary of this revision. junaire added a comment. Refactor code a little bit and fix wrong names. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116161/new/ https://reviews.llvm.org/D