[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

MaskRay added a comment. Sent D140363 to remove this incorrectly implemented option. Comment at: llvm/test/CodeGen/X86/ibtseal-small.ll:1 +; RUN: llc < %s -O2 -mtriple=x86_64-unknown-linux-gnu -x86-indirect-branch-tracking --code-model=small

[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

MaskRay added a comment. (I substantially edited my previous comment.) It now says this: > If the link mixes bitcode files and ELF relocatable files, for a function in > a bitcode file, `F.hasAddressTaken()` doesn't indicate that its address is > not taken by an ELF relocatable file. Reposito

[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

MaskRay added a comment. I have a question why the option is needed. if (IBTSeal) { return F.hasAddressTaken(); } // if !IBTSeal, fall into default case. LLVM_FALLTHROUGH; // Address taken or externally linked functions may be reachable. default: return (F.hasAddress

[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

MaskRay added a comment. Herald added subscribers: jsji, StephenFan. Herald added a project: All. The module flags metadata usage "Override" was wrong. I fixed it by using "Min". Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116070/new/ https://rev

[PATCH] D116070: [X86] Enable ibt-seal optimization when LTO is used in Kernel

This revision was automatically updated to reflect the committed changes. Closed by commit rG82af95029ec9: [X86] Enable ibt-seal optimization when LTO is used in Kernel (authored by joaomoreira, committed by pengfei). Herald added a project: clang. Herald added a subscriber: cfe-commits. Reposito