[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb2497e54356d: [PowerPC] Add generic fnmsub intrinsic (authored by qiucf). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added inline comments. Comment at: clang/test/CodeGen/PowerPC/builtins-ppc-xlcompat-math.c:98 // CHECK-NEXT:store double [[D:%.*]], double* [[D_ADDR]], align 8 +// CHECK-COUNT-3:load double, double* [[D_ADDR]], align 8 // CHECK-NEXT:[[TMP0:%.*]] = load double,

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf updated this revision to Diff 41. qiucf marked an inline comment as done. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116015/new/ https://reviews.llvm.org/D116015 Files: clang/lib/CodeGen/CGBuiltin.cpp clang/test/CodeGen/PowerPC/buil

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

shchenz accepted this revision as: shchenz. shchenz added a comment. This revision is now accepted and ready to land. Herald added a project: All. LGTM. Two nits about the comments and tests. Please wait for some days in case other reviews have some comments. Comment at: clang

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf updated this revision to Diff 411046. qiucf marked an inline comment as done. qiucf edited the summary of this revision. qiucf added a comment. Replace existing `ppc.fnmsub` and `ppc.fnmsubs`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1160

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added a comment. In D116015#3326148 , @shchenz wrote: >> hiding the semantics from the optimizer is sometimes a good thing and >> sometimes a bad thing). > > Agree. Imagining a case when the neg and fma (from fnmsub) can both be CSE-ed > with anot

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

shchenz added a comment. > hiding the semantics from the optimizer is sometimes a good thing and > sometimes a bad thing). Agree. Imagining a case when the neg and fma (from fnmsub) can both be CSE-ed with another neg and fma, so we can totally eliminate the fnmsub. But after we convert it to

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added a comment. gentle ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116015/new/ https://reviews.llvm.org/D116015 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.or

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf added a comment. In D116015#3203067 , @nemanjai wrote: > Converting more generic code to target-specific intrinsics is sometimes > necessary to ensure the generic IR doesn't get transformed in a way that is > disadvantageous. I believe that the de

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

nemanjai added a comment. Converting more generic code to target-specific intrinsics is sometimes necessary to ensure the generic IR doesn't get transformed in a way that is disadvantageous. I believe that the description of this review claims that to be the case for these negated FMA's. The ob

[PATCH] D116015: [PowerPC] Add generic fnmsub intrinsic

qiucf created this revision. qiucf added reviewers: rzurob, jsji, nemanjai, shchenz, PowerPC. Herald added subscribers: kbarton, hiraditya. qiucf requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Currently in Clang, we have