Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

zaks.anna added a comment. Committed earlier today in r245093. Thank you for contributing the checker! http://reviews.llvm.org/D11572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet updated this revision to Diff 32174. kulpreet added a comment. - Incorporated feedback from Devin's review - Moved LSM over to StringSet<> http://reviews.llvm.org/D11572 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/C

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

dcoughlin added inline comments. Comment at: lib/StaticAnalyzer/Checkers/LocalizationChecker.cpp:68 @@ +67,3 @@ + // Methods that require a localized string + mutable llvm::StringMap> UIMethods; + // Methods that return a localized string FWIW, #include "

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet updated this revision to Diff 32102. kulpreet added a comment. Fixed memory corruption bug with temporary std::string - found with address sanitizer. Now, all regression tests pass with MallocScribble on. http://reviews.llvm.org/D11572 Files: lib/StaticAnalyzer/Checkers/CMakeLists.

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet updated this revision to Diff 31894. kulpreet added a comment. Moved UIMethods over to StringMap so it should compile on Windows now. http://reviews.llvm.org/D11572 Files: lib/StaticAnalyzer/Checkers/CMakeLists.txt lib/StaticAnalyzer/Checkers/Checkers.td lib/StaticAnalyzer/Checke

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

zaks.anna added a comment. Committed in r244389. Thank you! http://reviews.llvm.org/D11572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

zaks.anna accepted this revision. zaks.anna added a comment. This revision is now accepted and ready to land. Thank you! LGTM. I'll commit this tomorrow. http://reviews.llvm.org/D11572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet added a comment. Updated diff to include Anna's suggestions. http://reviews.llvm.org/D11572 ___ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

kulpreet updated this revision to Diff 31481. kulpreet marked an inline comment as done. kulpreet added a comment. - By default (non-aggressive mode) the UnlocalizedStringChecker will ignore strings that are less than two characters long to avoid false positives such as @"-" - Added UIAlertView

Re: [PATCH] D11572: [Static Analyzer] Checker for OS X / iOS localizability issues

zaks.anna added inline comments. Comment at: test/Analysis/localization-aggressive.m:202 @@ +201,3 @@ +// EmptyLocalizationContextChecker tests +#define HOM(s) YOLOC(s) +#define YOLOC(x) NSLocalizedString(x, nil) How about something like this, where the last argum