This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa5de66c4c50b: [OpenCL] Add support of
__opencl_c_device_enqueue feature macro. (authored by azabaznov).
Repository:
rG LLVM Github Monorepo
CHANG
Anastasia accepted this revision.
Anastasia added a comment.
This revision is now accepted and ready to land.
LGTM! Thanks
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115640/new/
https://reviews.llvm.org/D115640
_
azabaznov marked an inline comment as done.
azabaznov added inline comments.
Comment at: clang/test/SemaOpenCL/storageclass.cl:2
// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -cl-std=CL1.2
-// RUN: %clang_cc1 %s -verify -pedantic -fsyntax-only -cl-std=CL3.0
-cl-ext=-__o
azabaznov updated this revision to Diff 402873.
azabaznov added a comment.
Add expected-no-diagnostics, fix misprint in test.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115640/new/
https://reviews.llvm.org/D115640
Files:
clang/include/clang/B
Anastasia added inline comments.
Comment at: clang/test/Misc/opencl-c-3.0.incorrect_options.cl:21
+
// CHECK-FP64: error: options cl_khr_fp64 and __opencl_c_fp64 are set to
different values
azabaznov wrote:
> Anastasia wrote:
> > Anastasia wrote:
> > > I can'
azabaznov updated this revision to Diff 399269.
azabaznov added a comment.
Rebase, remove extra 'verify'
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115640/new/
https://reviews.llvm.org/D115640
Files:
clang/include/clang/Basic/DiagnosticSemaKi
azabaznov added inline comments.
Comment at: clang/test/Misc/opencl-c-3.0.incorrect_options.cl:21
+
// CHECK-FP64: error: options cl_khr_fp64 and __opencl_c_fp64 are set to
different values
Anastasia wrote:
> Anastasia wrote:
> > I can't remember if we have d
Anastasia added inline comments.
Comment at: clang/test/Misc/opencl-c-3.0.incorrect_options.cl:21
+
// CHECK-FP64: error: options cl_khr_fp64 and __opencl_c_fp64 are set to
different values
Anastasia wrote:
> I can't remember if we have discussed this already
azabaznov marked 3 inline comments as done.
azabaznov added inline comments.
Comment at: clang/test/SemaOpenCL/invalid-device-enqueue-types-cl3.0.cl:5
+void f() {
+ clk_event_t e;
+ queue_t q;
Anastasia wrote:
> I know that many test have prefix "invalid" but I
azabaznov updated this revision to Diff 395390.
azabaznov added a comment.
Simplified running lines in tests, use 'verify' when validating features,
simplify condition in Sema
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115640/new/
https://revie
Anastasia added a comment.
> This feature requires support of opencl_c_generic_address_space and
opencl_c_program_scope_global_variables so diagnostics for that is provided as
well.
Do we have a spec issue for it or a PR? It would be good to list it here since
it is not yet published in the re
azabaznov created this revision.
azabaznov added reviewers: Anastasia, svenvh.
Herald added subscribers: Naghasan, ldrumm, yaxunl.
azabaznov requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This feature requires support of __opencl_c_generic
12 matches
Mail list logo
