kuhnel marked 4 inline comments as done.
kuhnel added a comment.
Thx @sammccall for your patience with this cleanup.
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:103
-static clang::clangd::Key kFileBeingProcessed;
+static clang::clangd::Key KFileBeingProcessed;
sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Thanks, this is great!
Just a few cases that regex couldn't quite understand, and one bona fide bug!
Comment at: clang-tools-extra/clangd/TUScheduler.cpp:103
-static
kuhnel marked 6 inline comments as done.
kuhnel added inline comments.
Comment at: clang-tools-extra/clangd/fuzzer/FuzzerClangdMain.cpp:15
+// NOLINTNEXTLINE(readability-identifier-naming)
extern "C" int LLVMFuzzerTestOneInput(const uint8_t *Data, size_t Size);
---
kuhnel updated this revision to Diff 403539.
kuhnel marked an inline comment as done.
kuhnel added a comment.
addressed review comments
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115634/new/
https://reviews.llvm.org/D115634
Files:
.clang-tidy
kuhnel updated this revision to Diff 403538.
kuhnel added a comment.
Herald added a subscriber: aheejin.
Re-created the patch as there were too many changes in the repo.
Excluding gtest Matchers from naming checks as gtest convention does not match
LLVM convention.
Repository:
rG LLVM Github
kuhnel added a comment.
Discussion in team sync, work for myself:
- most changes are in unittests --> propose something for the matchers
- cleaning up constants makes sense
- clean up this patch, then do another round of reviews
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
sammccall added a comment.
Generally looks good with a few nits for individual names.
The matcher cleanup is a problem though, because you haven't cleaned up the
functions created using the macros `MATCHER`, `MATCHER_P`, `MATCHER_P2` etc.
Presumably this is because names created through macros
