This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGcea81e95b05f: [clang-format] add support for cppm files
(authored by MyDeveloperDay).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTI
MyDeveloperDay updated this revision to Diff 394161.
MyDeveloperDay added a comment.
Add other support module file types for completeness
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115625/new/
https://reviews.llvm.org/D115625
Files:
clang/tools/clang-format/clang-format-diff.py
rsmith added a comment.
FWIW, Clang also supports `.ccm`, `.cxxm`, and `.c++m`. See
https://github.com/llvm/llvm-project/blob/main/clang/lib/Driver/Types.cpp#L273
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115625/new/
https://reviews.llvm.org/D115625
___
MyDeveloperDay updated this revision to Diff 393858.
MyDeveloperDay added a comment.
Move cppm to be with other cxx extensions
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115625/new/
https://reviews.llvm.org/D115625
Files:
clang/tools/clang-format/clang-format-diff.py
clang/tools
curdeius accepted this revision.
curdeius added a comment.
LGTM.
Comment at: clang/tools/clang-format/clang-format-diff.py:51
r'.*\.(cpp|cc|c\+\+|cxx|c|cl|h|hh|hpp|hxx|m|mm|inc|js|ts'
- r'|proto|protodevel|java|cs|json)',
+
MyDeveloperDay updated this revision to Diff 393851.
MyDeveloperDay added a comment.
Missed a comma
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D115625/new/
https://reviews.llvm.org/D115625
Files:
clang/tools/clang-format/clang-format-diff.py
clang/tools/clang-format/git-clang-for
MyDeveloperDay added inline comments.
Comment at: clang/tools/clang-format/git-clang-format:81
'mm', # ObjC++
- 'cc', 'cp', 'cpp', 'c++', 'cxx', 'hh', 'hpp', 'hxx', # C++
+ 'cc', 'cp', 'cpp', 'c++', 'cxx', 'hh', 'hpp', 'hxx', 'cppm' # C++
'cu', 'cuh',
ChuanqiXu accepted this revision.
ChuanqiXu added a comment.
This revision is now accepted and ready to land.
Thanks for the quick respond!
A note in the summary:
- C++20 Modules current style is to assign a new file suffix .cppm instead of
.cpp and .h
+ C++20 Modules current style is to as
MyDeveloperDay created this revision.
MyDeveloperDay added reviewers: ChuanqiXu, HazardyKnusperkeks, curdeius,
krasimir.
MyDeveloperDay added projects: clang, clang-format.
MyDeveloperDay requested review of this revision.
C++20 Modules current style is to assign a new file suffix .cppm instead o
