[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12c1022679d4: [AArch64] Lowering and legalization of strict FP16 (authored by john.brawn). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

dmgreen accepted this revision. dmgreen added a comment. This revision is now accepted and ready to land. OK Thanks. This LGTM then. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 ___ cfe-commits ma

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn added inline comments. Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:1386 + + IsStrictFPEnabled = true; } dmgreen wrote: > What are the ramifications of setting this to true? The behaviour with IsStrictFPEnabled = false is that strict f

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 422257. john.brawn added a comment. Removed clang test changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 Files: llvm/lib/CodeGen/SelectionDAG/LegalizeDAG.cpp llvm/lib/Target/AArch64/AArch64IS

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

dmgreen added a comment. I might have misunderstood which this patch was. Can you move the clang test into D118259 with the other? It seems like the same problem, and it looks like there should be enough llc tests to cover all the cases. Co

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn added a comment. Ping. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 419494. john.brawn added a comment. Adjusted formatting slightly. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115620/new/ https://reviews.llvm.org/D115620 Files: clang/test/CodeGen/aarch64-v8.2a-fp16-intrinsics-constrained.c llvm/lib/CodeG

[PATCH] D115620: [AArch64] Lowering and legalization of strict FP16

john.brawn updated this revision to Diff 416141. john.brawn set the repository for this revision to rG LLVM Github Monorepo. john.brawn added a comment. Herald added a project: clang. Herald added a subscriber: cfe-commits. Rebase and ping. Repository: rG LLVM Github Monorepo CHANGES SINCE LA