[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. tianshilei1992 marked an inline comment as done. Closed by commit rGc7a589a2c4e2: [Clang][OpenMP] Add the support for atomic compare in parser (authored by tianshilei19

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

ABataev accepted this revision. ABataev added a comment. This revision is now accepted and ready to land. LG Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 ___

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 marked 2 inline comments as done. tianshilei1992 added inline comments. Comment at: clang/lib/Sema/SemaOpenMP.cpp:11398-11400 +// TODO: For now we emit an error here and in emitOMPAtomicExpr we ignore +// code gen. +Diag(Body->getBeginLoc(), diag::err_o

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 396122. tianshilei1992 added a comment. fix comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/OpenMPClause.h clang/in

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

ABataev added inline comments. Comment at: clang/include/clang/AST/OpenMPClause.h:2234 +/// In this example directive '#pragma omp atomic' has 'compare' clause. +class OMPCompareClause : public OMPClause { +public: `final` Comment at: clang/lib

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 395929. tianshilei1992 added a comment. just emit the error but not return Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/Ope

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 planned changes to this revision. tianshilei1992 added a comment. I think I'm going to build another patches on top of this one and land them altogether. In this way, I don't need to add any test in this patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION ht

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 395208. tianshilei1992 added a comment. remove unexpected change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/OpenMPClause.

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 395207. tianshilei1992 added a comment. Herald added a project: Flang. update one test case and flang fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 added a comment. In D115561#3189179 , @jdoerfert wrote: > All good but parser tests needed. Since we directly emit an error in Sema, I'm not sure if we can do the same thing as `clang/test/OpenMP/atomic_ast_print.cpp` because we can alway

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 added a comment. In D115561#3190243 , @mikerice wrote: > Note you'll want to add a line to flang/lib/Semantics/check-omp-structure.cpp > for the new clause or the flang build will fail. > > CHECK_SIMPLE_CLAUSE(Compare, OMPC_compare) Thank

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

mikerice added a comment. Note you'll want to add a line to flang/lib/Semantics/check-omp-structure.cpp for the new clause or the flang build will fail. CHECK_SIMPLE_CLAUSE(Compare, OMPC_compare) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11556

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

jdoerfert added a comment. All good but parser tests needed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 ___ cfe-commits mailing list cfe-commits@lists.llvm

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 393656. tianshilei1992 added a comment. rebase and remove unnecessary changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 393634. tianshilei1992 added a comment. continue to remove more unrelated code changes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/c

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 393633. tianshilei1992 added a comment. further remove code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/OpenMPClause.h c

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 updated this revision to Diff 393629. tianshilei1992 added a comment. remove useless code Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115561/new/ https://reviews.llvm.org/D115561 Files: clang/include/clang/AST/OpenMPClause.h c

[PATCH] D115561: [Clang][OpenMP] Add the support for atomic compare in parser

tianshilei1992 created this revision. tianshilei1992 added reviewers: jdoerfert, ABataev, carlo.bertolli. Herald added subscribers: arphaman, guansong, yaxunl. tianshilei1992 requested review of this revision. Herald added subscribers: llvm-commits, cfe-commits, sstefan1. Herald added projects: cla