[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia added a comment. In D115523#3284446 , @yaxunl wrote: > In D115523#3266584 , @Anastasia > wrote: > >> In D115523#3240870 , @yaxunl wrote: >> >>> In D115523#32378

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

yaxunl added a comment. In D115523#3266584 , @Anastasia wrote: > In D115523#3240870 , @yaxunl wrote: > >> In D115523#3237857 , @Anastasia >> wrote: >> >>> In D115523#3237

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia added a comment. In D115523#3240870 , @yaxunl wrote: > In D115523#3237857 , @Anastasia > wrote: > >> In D115523#3237410 , @yaxunl wrote: >> >>> It is possible t

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

yaxunl added a comment. In D115523#3237857 , @Anastasia wrote: > In D115523#3237410 , @yaxunl wrote: > >> It is possible that block kernels are defined and invoked in static >> functions, therefore two block kern

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia added a comment. In D115523#3237410 , @yaxunl wrote: > It is possible that block kernels are defined and invoked in static > functions, therefore two block kernels in different TU's may have the same > name. Making such kernels external may ca

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

yaxunl added a comment. It is possible that block kernels are defined and invoked in static functions, therefore two block kernels in different TU's may have the same name. Making such kernels external may cause duplicate symbols. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTIO

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b85800bfd6c: [OpenCL] Set external linkage for block enqueue kernels (authored by svenvh). Repository: rG LLVM Github Monorepo CHANGES SINCE LAS

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

Anastasia accepted this revision. Anastasia added a comment. This revision is now accepted and ready to land. LGTM! I agree according to the OpenCL programming model attributes `internal spir_kernel` together on the same function create a contradiction because kernel functions are expected to ha

[PATCH] D115523: [OpenCL] Set external linkage for block enqueue kernels

svenvh created this revision. svenvh added reviewers: Anastasia, yaxunl. svenvh added a project: clang. Herald added a subscriber: ldrumm. svenvh requested review of this revision. Herald added a subscriber: cfe-commits. All kernels can be called from the host as per the SPIR_KERNEL calling conven