[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG09a704c5efba: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO. (authored by luna). Repository: rG LLVM Github Monorepo CHANGES SI

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna added a comment. In D115492#3192624 , @tejohnson wrote: > lgtm after adding a description to test as noted below. Done. Thanks for review and feedback! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 394293. luna added a comment. Describe what the test case devirt_hybrid_after_filtering_unreachable.ll is for. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files: c

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

tejohnson accepted this revision. tejohnson added a comment. This revision is now accepted and ready to land. lgtm after adding a description to test as noted below. Comment at: llvm/test/ThinLTO/X86/devirt_hybrid_after_filtering_unreachable.ll:1 +; Generate split module with s

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 394281. luna marked 2 inline comments as done. luna added a comment. Revise based on comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files: clang/test/CodeGe

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna marked 5 inline comments as done. luna added inline comments. Comment at: llvm/lib/Transforms/IPO/WholeProgramDevirt.cpp:396 + } + // Identifies a function as unreachable if and only if + // 1) All summaries are live. tejohnson wrote: > Actually I think w

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

tejohnson added inline comments. Comment at: llvm/lib/Analysis/ModuleSummaryAnalysis.cpp:241 +// to be unreachable; if it returns false, `F` might still +// be unreachble but not covered by this helper function. +static bool mustBeUnreachableFunction(const Function &F) {

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 393927. luna added a comment. Use type `auto` for GUID to fix a compile error. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files: clang/test/CodeGen/thinlto-distri

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 393921. luna added a comment. Use GUID computed with exported function name as a fallback to look up index when there isn't an entry for current function GUID. - Based on feedback in https://reviews.llvm.org/D115203#inline-1104045 - The entry might be absent wh

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 393531. luna added a comment. Remove verbose attributes from test case Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files: clang/test/CodeGen/thinlto-distributed-cf

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna updated this revision to Diff 393392. luna added a comment. Revert unit test that shouldn't be affected. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115492/new/ https://reviews.llvm.org/D115492 Files: clang/test/CodeGen/thinlto-distribute

[PATCH] D115492: [LTO] Ignore unreachable virtual functions in WPD in hybrid LTO

luna created this revision. Herald added subscribers: ormris, pengfei, arphaman, steven_wu, hiraditya, inglorion. luna requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. - In FunctionSummary, add a new bit `mustBeUnreachable