[PATCH] D115440: [clang][auto-init] Provide __builtin_alloca_uninitialized

2021-12-09 Thread Alexander Potapenko via Phabricator via cfe-commits
glider added a comment. In D115440#3182585 , @melver wrote: > For completeness, also provide __builtin_alloca_with_align_uninitialized(). Please make sure to update the patch description. (You may have done already, but arc doesn't pull them automaticall

[PATCH] D115440: [clang][auto-init] Provide __builtin_alloca_uninitialized

2021-12-09 Thread Marco Elver via Phabricator via cfe-commits
melver updated this revision to Diff 393122. melver marked an inline comment as done. melver added a comment. For completeness, also provide __builtin_alloca_with_align_uninitialized(). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115440/new/ http

[PATCH] D115440: [clang][auto-init] Provide __builtin_alloca_uninitialized

2021-12-09 Thread Marco Elver via Phabricator via cfe-commits
melver added inline comments. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3436 case Builtin::BI__builtin_alloca_with_align: { Value *Size = EmitScalarExpr(E->getArg(0)); glider wrote: > For the sake of completeness, shall we also implement an uninitiali

[PATCH] D115440: [clang][auto-init] Provide __builtin_alloca_uninitialized

2021-12-09 Thread Alexander Potapenko via Phabricator via cfe-commits
glider added a comment. I second this proposal. https://reviews.llvm.org/D60548 suggests to handle this case using a pragma, but the required change seems to be more intrusive. Comment at: clang/lib/CodeGen/CGBuiltin.cpp:3436 case Builtin::BI__builtin_alloca_with_align: {

[PATCH] D115440: [clang][auto-init] Provide __builtin_alloca_uninitialized

2021-12-09 Thread Marco Elver via Phabricator via cfe-commits
melver created this revision. melver added reviewers: jfb, pcc, glider. melver requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. When `-ftrivial-auto-var-init=` is enabled, allocas unconditionally receive auto-initialization since [1]. In ce