[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-11 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG93fbaa46c82a: Revert "Revert "[clang][dataflow] Add framework for testing analyses."" (authored by ymandel). Repository: rG LLVM Github Monorepo

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-11 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 393705. ymandel added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341 Files: clang/include/clang/Analysis/FlowSensitive/TypeErasedDataflowAnalysis

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-10 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 393513. ymandel added a comment. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. renames the `testing` namespace to `test` cleans up the code the implementation of `operator<<` for dataflow state. Repository: rG LLVM Github Monorepo

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-10 Thread Nico Weber via Phabricator via cfe-commits
thakis added a comment. Looks like this breaks building on Windows: http://45.33.8.238/win/50614/step_4.txt Please take a look! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341 __

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-10 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5a40df638181: [clang][dataflow] Add framework for testing analyses. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-10 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 393477. ymandel added a comment. Remove the SFINAE guard and add `operator<<` for `NoopLattice` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341 Files: clang/include

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-10 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:47-48 +template () + << std::declval())> +std::ostream &operator<<(std::ostream &OS, This SFINAE guard doesn't work on some platforms,

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-10 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47d526d67e3c: [clang][dataflow] Add framework for testing analyses. (authored by ymandel). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-10 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 393460. ymandel added a comment. add missing build dependency Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341 Files: clang/include/clang/Analysis/FlowSensitive/Type

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-09 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun accepted this revision. xazax.hun added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341 __

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-09 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 393221. ymandel marked 2 inline comments as done. ymandel added a comment. rebasing onto latest version of parent patch Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-09 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel marked 2 inline comments as done. ymandel added a comment. Thanks for the great comments and the fast response time! Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:134 + +transferBlock( +BlockStates, *Block, Env, Analysis, --

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-09 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel updated this revision to Diff 393218. ymandel added a comment. responding to review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115341/new/ https://reviews.llvm.org/D115341 Files: clang/include/clang/Analysis/FlowSensitive/Typ

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-08 Thread Gábor Horváth via Phabricator via cfe-commits
xazax.hun added inline comments. Comment at: clang/unittests/Analysis/FlowSensitive/TestingSupport.h:48 + << std::declval())> +std::ostream &operator<<(std::ostream &OS, + const DataflowAnalysisState &S) { This

[PATCH] D115341: [clang][dataflow] Add framework for testing analyses.

2021-12-08 Thread Yitzhak Mandelbaum via Phabricator via cfe-commits
ymandel created this revision. ymandel added reviewers: gribozavr2, sgatev, xazax.hun. Herald added subscribers: rnkovacs, mgorny. ymandel requested review of this revision. Herald added a project: clang. Adds a general-purpose framework to support testing of dataflow analyses. Repository: rG