[PATCH] D115248: [clang] Fix Bug 28101

2021-12-08 Thread PoYao Chang via Phabricator via cfe-commits
rZhBoYao updated this revision to Diff 392774. rZhBoYao edited the summary of this revision. rZhBoYao added a comment. I added a test. There were 17 module and PCH related failed tests on my local machine; however, when I ran the test on then ToT

[PATCH] D115248: [clang] Fix Bug 28101

2021-12-07 Thread Aaron Ballman via Phabricator via cfe-commits
aaron.ballman added a comment. FWIW, this appears to cause quite a few failures in precommit CI that should be addressed as well: https://buildkite.com/llvm-project/premerge-checks/builds/68803#45a9b858-fa66-4a4b-8c4a-20c2cef820e5 Failed Tests (11): Clang :: CXX/basic/basic.lookup/basic.l

[PATCH] D115248: [clang] Fix Bug 28101

2021-12-07 Thread Erich Keane via Phabricator via cfe-commits
erichkeane added a comment. Can you add some tests please? Additionally, we don't typically use LLVM_UNLIKELY like you did there. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 ___ cfe-commits mai

[PATCH] D115248: [clang] Fix Bug 28101

2021-12-07 Thread PoYao Chang via Phabricator via cfe-commits
rZhBoYao updated this revision to Diff 392399. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 Files: clang/lib/Parse/ParseDecl.cpp clang/lib/Sema/SemaDeclCXX.cpp Index: clang/lib/Sema/SemaDeclCXX.cpp ==

[PATCH] D115248: [clang] Fix Bug 28101

2021-12-07 Thread PoYao Chang via Phabricator via cfe-commits
rZhBoYao created this revision. rZhBoYao added reviewers: rsmith, aaron.ballman, erichkeane, v.g.vassilev, rnk. rZhBoYao added a project: clang. rZhBoYao requested review of this revision. Herald added a subscriber: cfe-commits. This should fix Bug 28101