[PATCH] D115248: [Clang] Fix PR28101

This revision was automatically updated to reflect the committed changes. Closed by commit rG355f1c75aa66: [Clang] Fix PR28101 (authored by rZhBoYao). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 Files:

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417648. rZhBoYao edited the summary of this revision. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao added a comment. Added an entry in release notes. Waiting for CI... Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D115248: [Clang] Fix PR28101

erichkeane added a comment. Nope, see release notes here: https://github.com/llvm/llvm-project/blob/main/clang/docs/ReleaseNotes.rst CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 ___ cfe-commits m

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao added a comment. By 'release notes' do you mean a more detailed commit message? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https:

[PATCH] D115248: [Clang] Fix PR28101

erichkeane added a comment. Please add a 'release notes'. Otherwise, LGTM as long as the bots are ok with it! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 ___ cfe-commits mailing list cfe-commit

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417632. rZhBoYao marked 3 inline comments as done. rZhBoYao added a comment. This passes check-clang-semacxx on my machine. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 Files: clang/lib/Sema/SemaDecl

[PATCH] D115248: [Clang] Fix PR28101

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3430 << D.getName().TemplateId->LAngleLoc; + if (cast(CurContext)->getDeclName() == Name) +Diag(Loc, diag::err_member_name_of_class) << Name; rZhBoYao wrote: > er

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao marked 3 inline comments as done. rZhBoYao added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3430 << D.getName().TemplateId->LAngleLoc; + if (cast(CurContext)->getDeclName() == Name) +Diag(Loc, diag::err_member_name_of_class) << Na

[PATCH] D115248: [Clang] Fix PR28101

erichkeane added inline comments. Comment at: clang/lib/Sema/SemaDeclCXX.cpp:3430 << D.getName().TemplateId->LAngleLoc; + if (cast(CurContext)->getDeclName() == Name) +Diag(Loc, diag::err_member_name_of_class) << Name; I see we are diagnos

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417504. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao added a comment. Diagnose "same name as its class" before setting the declarator invalid as otherwise it would not be diagnosed. This also aligns with gcc's behavior.

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417475. rZhBoYao added a comment. Don't break template declarations. re-clang-format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115248/new/ https://reviews.llvm.org/D115248 Files: clang/lib/Sema/SemaDeclCXX.cpp clang/test/SemaCXX/PR28101.cp

[PATCH] D115248: [Clang] Fix PR28101

rZhBoYao updated this revision to Diff 417461. rZhBoYao retitled this revision from "[clang] Fix PR28101" to "[Clang] Fix PR28101". rZhBoYao edited the summary of this revision. rZhBoYao added a reviewer: cor3ntin. rZhBoYao set the repository for this revision to rG LLVM Github Monorepo. rZhBoYao

[PATCH] D115248: [clang] Fix PR28101

aaron.ballman added inline comments. Comment at: clang/lib/Parse/ParseDecl.cpp:6485-6488 +if (getLangOpts().CPlusPlus && !D.getIdentifier() && +D.getName().getKind() == UnqualifiedIdKind::IK_TemplateId && +D.getContext() == DeclaratorContext::Member) + D.