[PATCH] D115064: [clang-format][NFC] Replace deque with vector

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG35493b45603f: [clang-format][NFC] Replace deque with vector (authored by HazardyKnusperkeks). Repository: rG LLVM Github Monorepo CHANGES SINCE L

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks updated this revision to Diff 397131. HazardyKnusperkeks set the repository for this revision to rG LLVM Github Monorepo. HazardyKnusperkeks added a comment. Now with SmallVector. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks added a comment. In D115064#3172860 , @MyDeveloperDay wrote: > Even if you choose a number, beyond that number it behaves like a vector > (just without the data being on the stack), its really good for small vectors > but its not bad

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

MyDeveloperDay added a comment. Even if you choose a number, beyond that number it behaves like a vector (just without the data being on the stack), its really good for small vectors but its not bad for large ones. I'm not sure what the default N is if you don't specify a number? (0?) CHANGES

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks added a comment. In D115064#3171950 , @owenpan wrote: > In D115064#3170615 , @curdeius > wrote: > >> Maybe using `llvm::SmallVector` with some well-thought (data-based) static >> number of ele

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

owenpan added a comment. In D115064#3170615 , @curdeius wrote: > Maybe using `llvm::SmallVector` with some well-thought (data-based) static > number of elements would be better here, WDYT? I tend to agree as LLVM style

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks updated this revision to Diff 391855. HazardyKnusperkeks added a comment. Formatting fixed. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115064/new/ https://reviews.llvm.org/D115064 Files: clang/lib/Format/UnwrappedLineFormatter.cpp Index: clang/lib/Format/Unwra

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks added a comment. In D115064#3170615 , @curdeius wrote: > Deque, contrary to the vector, doesn't need to move the elements when > growing. I'm not sure if that's relevant here though. > Have you checked what's on average the maximum siz

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

MyDeveloperDay accepted this revision. MyDeveloperDay added a comment. This revision is now accepted and ready to land. This seems reasonable its as if we only ever push_back and iterate backwards? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11506

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

curdeius added a comment. Deque, contrary to the vector, doesn't need to move the elements when growing. I'm not sure if that's relevant here though. Have you checked what's on average the maximum size of `Path` on some larger repo? Maybe using `llvm::SmallVector` with some well-thought (data-ba

[PATCH] D115064: [clang-format][NFC] Replace deque with vector

HazardyKnusperkeks created this revision. HazardyKnusperkeks added reviewers: MyDeveloperDay, curdeius, owenpan. HazardyKnusperkeks added a project: clang-format. HazardyKnusperkeks requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. I think th