[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

This revision was automatically updated to reflect the committed changes. Closed by commit rG13a351e862ba: [clang][deps] Use MemoryBuffer in minimizing FS (authored by jansvoboda11). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

dexonsmith accepted this revision. dexonsmith added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://reviews.llvm.org/D115043 __

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 added inline comments. Comment at: clang/include/clang/Tooling/DependencyScanning/DependencyScanningFilesystem.h:49 - /// running out of file descriptors. + /// mismatching size of the file. static CachedFileSystemEntry createFileEntry(StringRef Filename,

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 updated this revision to Diff 392745. jansvoboda11 marked an inline comment as done. jansvoboda11 added a comment. Update comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://reviews.llvm.org/D115043 Files: clan

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 marked 2 inline comments as done. jansvoboda11 added inline comments. Comment at: llvm/include/llvm/Support/SmallVectorMemoryBuffer.h:54 + /// and invoke the given function right after the move. + SmallVectorMemoryBuffer( + SmallVectorImpl &&SV, --

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 updated this revision to Diff 392717. jansvoboda11 added a comment. Rebase on top of D115331 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115043/new/ https://reviews.llvm.org/D115043 Files: clang

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:64-70 MinimizedFileContents.push_back('\0'); - Result.Contents = std::move(MinimizedFileContents); - // Now make the null terminator implicit again, so that C

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 added inline comments. Comment at: llvm/include/llvm/Support/SmallVectorMemoryBuffer.h:54 + /// and invoke the given function right after the move. + SmallVectorMemoryBuffer( + SmallVectorImpl &&SV, I'm not happy with introducing new (hacky) c

[PATCH] D115043: [clang][deps] Use MemoryBuffer in minimizing FS

jansvoboda11 created this revision. jansvoboda11 added reviewers: Bigcheese, dexonsmith, arphaman. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. This patch avoids unnecessarily copying `mmap`-ed memory into