[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 marked 3 inline comments as done. jansvoboda11 added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:25-31 llvm::ErrorOr Stat = (*MaybeFile)->status(); if (!Stat) return Stat.getError(); llvm::vfs::F

[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 updated this revision to Diff 394600. jansvoboda11 marked 5 inline comments as done. jansvoboda11 added a comment. Rebase on top of D115346 , apply suggested changes to the cache structure and allocation strategy. Repository: rG LLVM Github Monor

[PATCH] D114966: [clang][deps] Split filesystem caches

dexonsmith added inline comments. Comment at: clang/lib/Tooling/DependencyScanning/DependencyScanningFilesystem.cpp:253-255 + if (SharedOriginalContents.WasInserted) +SharedStat->Stat = +readFile(Filename, getUnderlyingFS(), SharedOriginalContents.Value); --

[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 marked 2 inline comments as done. jansvoboda11 added a comment. In D114966#3168108 , @dexonsmith wrote: > Thanks for working on this; seems like a great start. Thanks a lot for the extensive feedback! I'll work through it and create prep p

[PATCH] D114966: [clang][deps] Split filesystem caches

dexonsmith added a comment. Thanks for working on this; seems like a great start. At a high-level: - We should check overhead. It'd be good to benchmark scanning LLVM with `clang-scan-deps` before and after this change. - The locking is getting harder to track, since the acquisition and release

[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 updated this revision to Diff 391369. jansvoboda11 added a comment. Add unit test, IWYU. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114966/new/ https://reviews.llvm.org/D114966 Files: clang/include/clang/Tooling/DependencyScannin

[PATCH] D114966: [clang][deps] Split filesystem caches

jansvoboda11 created this revision. Herald added subscribers: dexonsmith, hiraditya. jansvoboda11 requested review of this revision. Herald added projects: clang, LLVM. Herald added subscribers: llvm-commits, cfe-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D114966 Fil