[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

arsenm resigned from this revision. arsenm added a comment. This revision is now accepted and ready to land. Herald added subscribers: kosarev, MaskRay. Herald added a project: All. This should be abandoned, the flag is gone Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

JonChesterfield added a comment. Probably obsoleted by 729bf9b26b657df8 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114865/new/ https://reviews.llvm.org/D114865 _

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

JonChesterfield added a comment. Run a bunch of tests locally. This patch or something equivalent is a precondition on using the new device runtime on amdgpu, which we are very much out of time on (see D114890 which will break us as soon as it lands without th

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

JonChesterfield added a comment. Fixed abi was set to true in D96340 . At that point, indirect calls probably worked. This was replaced with some dubious fine grain attribute handling in D99347 , at which point indirect calls are

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

JonChesterfield accepted this revision. JonChesterfield added a comment. This would unblock a patch that has been waiting for us since May (D102107 ). Once your patches land and make the flag unnecessary we can take it back out. I asked for this because I need t

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

arsenm requested changes to this revision. arsenm added a comment. This revision now requires changes to proceed. I have a patch to enable this by default and I do not want to spread uses of this flag around Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[PATCH] D114865: [AMDGPU][OpenMP] Use -amdgpu-fixed-function-abi

pdhaliwal created this revision. pdhaliwal added reviewers: arsenm, JonChesterfield. Herald added subscribers: kerbowa, guansong, t-tye, tpr, dstuttard, yaxunl, nhaehnle, jvesely, kzhuravl. pdhaliwal requested review of this revision. Herald added subscribers: openmp-commits, cfe-commits, sstefan1