This revision was automatically updated to reflect the committed changes.
Closed by commit rGc4582a689c2c: [Analysis] Ignore casts and unary ops for
uninitialized values (authored by void).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114848/new/
h
void updated this revision to Diff 392281.
void added a comment.
Simplify the loop.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114848/new/
https://reviews.llvm.org/D114848
Files:
clang/lib/Analysis/UninitializedValues.cpp
clang/test/Analysi
nickdesaulniers added inline comments.
Comment at: clang/lib/Analysis/UninitializedValues.cpp:819-820
+// semantic analysis passes.
+while (isa(Ex))
+ Ex = stripCasts(C, dyn_cast(Ex)->getSubExpr());
+
void wrote:
> nickdesaulniers wrote:
> > Q: are t
void added inline comments.
Comment at: clang/lib/Analysis/UninitializedValues.cpp:819-820
+// semantic analysis passes.
+while (isa(Ex))
+ Ex = stripCasts(C, dyn_cast(Ex)->getSubExpr());
+
nickdesaulniers wrote:
> Q: are there any unary operators th
nickdesaulniers added inline comments.
Comment at: clang/lib/Analysis/UninitializedValues.cpp:819-820
+// semantic analysis passes.
+while (isa(Ex))
+ Ex = stripCasts(C, dyn_cast(Ex)->getSubExpr());
+
Q: are there any unary operators that are not cas
void added a comment.
Friendly ping to reviewers. :-)
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114848/new/
https://reviews.llvm.org/D114848
___
cfe-commits mailing list
cfe-commits@lists.llvm.org
ht
void updated this revision to Diff 391086.
void marked an inline comment as done.
void added a comment.
Pretend that I've spoken English for most of my lyfe.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114848/new/
https://reviews.llvm.org/D114848
void added inline comments.
Comment at: clang/lib/Analysis/UninitializedValues.cpp:594
// If the predecessor's terminator is an "asm goto" that initializes
- // the variable, then it won't be counted as "initialized" on the
- // non-fallthrough paths.
nathanchance added a comment.
I tested the problematic Linux kernel configuration that uncovered this issue
with this patch and the issue was resolved. I tested an x86_64 allmodconfig
build and did not see any warnings.
Comment at: clang/lib/Analysis/UninitializedValues.cpp:5
void created this revision.
void added reviewers: dblaikie, nickdesaulniers.
void requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
A series of unary operators and casts may obscure the variable we're
trying to analyze. Ignore them for the un
10 matches
Mail list logo