[PATCH] D114842: [lld-macho] Remove old macho darwin lld

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG9e3552523ebd: [lld-macho] Remove old macho darwin lld (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

oontvoo accepted this revision. oontvoo added a comment. LG - thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 ___ cfe-commits mailing list cfe-commits@l

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 391065. keith marked an inline comment as done. keith added a comment. Remove lld/lib directory Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

thevinster added inline comments. Comment at: lld/lib/CMakeLists.txt:1 add_subdirectory(Core) Just wondering, can't we delete this too? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.l

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390911. keith added a comment. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.txt lld/include/lld/Common/Driver.h lld/include/ll

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390910. keith added a comment. Stragglers Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.org/D114842 Files: lld/CMakeLists.txt lld/include/lld/Common/Driver.h lld/include/ll

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith updated this revision to Diff 390908. keith added a comment. Herald added subscribers: dang, sstefan1, mgrang. Herald added a reviewer: jdoerfert. Herald added a project: lld-macho. Herald added a reviewer: lld-macho. More deletions Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. In D114842#3163229 , @int3 wrote: > lgtm. Could you make a post to llvm-dev before landing this? Thanks! Sent! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://revi

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. In D114842#3163232 , @MaskRay wrote: > Consider moving the clang driver change to a separate change so that the > removal is a more pure file deletion (other than some build system changes) Fair enough, I'll submit as a follow up

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

MaskRay accepted this revision. MaskRay added a comment. Consider moving the clang driver change to a separate change so that the removal is a more pure file deletion (other than some build system changes) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

int3 accepted this revision. int3 added a comment. This revision is now accepted and ready to land. lgtm. Could you make a post to llvm-dev before landing this? Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://reviews.llvm.

[PATCH] D114842: [lld-macho] Remove old macho darwin lld

keith added a comment. I chose to remove the darwinnew / darwinold symlinks here as well. Let me know if you all think we should leave those around for a while for some reason Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114842/new/ https://revie