[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

This revision was automatically updated to reflect the committed changes. Closed by commit rGc490f8feb71e: [clangd][StdSymbolMap] Prefer std::remove from algorithm (authored by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114724/new/ htt

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

kadircet updated this revision to Diff 399300. kadircet marked 5 inline comments as done. kadircet added a comment. - Change the variant acception mechanism to work with specific variants. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114724/new/ h

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

sammccall added a comment. In D114724#3163579 , @kadircet wrote: > for whatever reason I remembered the std::remove to have been referenced > ~17k. looks like these two are much closer. I don't think it makes sense to > prefer one or the other here. Ag

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

kadircet added a comment. | 1658 | remove | NULL | | 1731 | std::__u::remove | llvm/include/c++/v1/__algorithm/remove.h | | for whatever reason I remembered the std::remove to have been referenced ~17k. looks like these two are much closer. I don't t

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

kadircet added inline comments. Comment at: clang-tools-extra/clangd/StdSymbolMap.inc:958 SYMBOL(remainder, std::, ) -SYMBOL(remove, std::, ) SYMBOL(remove_all_extents, std::, ) sammccall wrote: > Is the stdio version so uncommon we are willing to be wrong abou

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

sammccall added inline comments. Comment at: clang-tools-extra/clangd/StdSymbolMap.inc:958 SYMBOL(remainder, std::, ) -SYMBOL(remove, std::, ) SYMBOL(remove_all_extents, std::, ) Is the stdio version so uncommon we are willing to be wrong about it? For `move`

[PATCH] D114724: [clangd][StdSymbolMap] Prefer std::remove from algorithm

kadircet created this revision. kadircet added a reviewer: sammccall. Herald added subscribers: usaxena95, arphaman. kadircet requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. std::remove from algorithm is a