xazax.hun added a comment.
I don't have strong opinions, just some small preferences, feel free to ignore
them:
- Using ASTMatchers feels a bit heavy weight for this task to me. Simply
enumerating the function definitions in the `TranslationUnitDecl` should be
sufficient for these tests.
- The
ymandel added a comment.
Looks good, but why split the test into its own directory? I see that the
implementation file is in clang/lib/Analysis and, in general, the lib and
unittest directories are often flatter than the corresponding include
directories. Maybe just put it directly into unittes
sgatev created this revision.
sgatev added reviewers: ymandel, xazax.hun, gribozavr2.
Herald added subscribers: rnkovacs, mgorny.
sgatev requested review of this revision.
Herald added a project: clang.
This adds unit tests for the PostOrderCFGView class which will be
used as part of the implement