[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

aaron.ballman closed this revision. aaron.ballman added a comment. Thank you for the new functionality, I've committed on your behalf in 8680f951c21e675a110e79c9b8dc59bb94290b01 Comment at: clang/lib/Sema/S

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire added a comment. In D114688#3176567 , @aaron.ballman wrote: > In D114688#3176433 , @fhahn wrote: > >> I think it might be good to split off the refactoring of >> `SemaBuiltinElementwiseMathOneArg`-> >>

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land. In D114688#3176433 , @fhahn wrote: > I think it might be good to split off the refactoring of > `SemaBuiltinElementwiseMathOneArg`-> >

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 392405. junaire added a comment. Fix typos CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/include

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added a comment. Thanks for the update, it looks like it should be in line with @aaron.ballman's suggestions! I think it might be good to split off the refactoring of `SemaBuiltinElementwiseMathOneArg`-> `PrepareBuiltinElementwiseMathOneArgCall` and the update for `BI__builtin_elementwis

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 391574. junaire added a comment. No more lambdas CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang/i

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

aaron.ballman added a comment. In D114688#3166870 , @junaire wrote: > I didn't know if I understand Aaron's words right, but I think I can update > the patch first... I think you understood my suggestion pretty well, thanks! Comment

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 391316. junaire added a comment. I didn't know if I understand Aaron's words right, but I think I can update the patch first... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:16727-16728 QualType TyA = A.get()->getType(); - if (checkMathBuiltinElementType(*this, ArgLoc, TyA)) + if (checkMathBuiltinElementType(*this, ArgLoc, TyA) || + ExtraCheck(TyA, ArgLoc)) return

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

aaron.ballman added inline comments. Comment at: clang/include/clang/Basic/Builtins.def:649 BUILTIN(__builtin_elementwise_min, "v.", "nct") +BUILTIN(__builtin_elementwise_ceil, "v.", "nct") BUILTIN(__builtin_reduce_max, "v.", "nct") If we're doing ceil, should

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/lib/Sema/SemaChecking.cpp:2104 +TheCall, [this](QualType ArgTy, SourceLocation ArgLoc) -> bool { + QualType EltTy = ArgTy; + if (auto *VecTy = EltTy->getAs()) Could you add a com

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 391016. junaire marked an inline comment as done. junaire added a comment. Apply some awesome suggestions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added inline comments. Comment at: clang/include/clang/Basic/DiagnosticSemaKinds.td:11337 +def err_builtin_float_invalid_arg_type: Error < + "%ordinal0 argument must be a " There's no need to add a new error message here. `err_builtin_invalid_arg_type`

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 390914. junaire added a comment. Adjust code style CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td clang

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire updated this revision to Diff 390912. junaire added a comment. Reuse existing code. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114688/new/ https://reviews.llvm.org/D114688 Files: clang/include/clang/Basic/Builtins.def clang/include/clang/Basic/DiagnosticSemaKinds.td cl

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

fhahn added a comment. Thanks for the patch! I left a suggestion inline. Comment at: clang/lib/Sema/SemaChecking.cpp:16721 +bool Sema::SemaBuiltinElementwiseMathFloatArg(CallExpr *TheCall) { + if (checkArgCount(*this, TheCall, 1)) If I understand correctly,

[PATCH] D114688: [Clang] Add __builtin_elementwise_ceil

junaire created this revision. junaire added reviewers: fhahn, aaron.ballman, scanon, craig.topper. junaire requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. This patch implements one of the missing builtin functions specified in https://rev