This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGdf08b2fe8b35: [AArch64] Avoid crashing on invalid
-Wa,-march= values (authored by dim).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST AC
tschuett accepted this revision.
tschuett added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114677/new/
https://reviews.llvm.org/D114677
___
dim updated this revision to Diff 390218.
dim added a comment.
Address review comments.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114677/new/
https://reviews.llvm.org/D114677
Files:
clang/lib/Driver/ToolChains/Arch/AArch64.cpp
clang/test/D
tschuett added a comment.
There is precedence for checking `WaMArch.size()` in the file. I would expected
`!WaMArch.empty()`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114677/new/
https://reviews.llvm.org/D114677
_
tschuett added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/AArch64.cpp:263
if (!success)
-D.Diag(diag::err_drv_clang_unsupported) << A->getAsString(Args);
+D.Diag(diag::err_drv_clang_unsupported)
+<< (WaMArch.size() ? "-march=" + WaMArch.str()
dim created this revision.
dim added reviewers: jcai19, ostannard, DavidSpickett, nickdesaulniers.
Herald added subscribers: kristof.beyls, krytarowski, arichardson.
dim requested review of this revision.
Herald added a project: clang.
As reported in https://bugs.freebsd.org/260078, the gnutls Mak
