This revision was automatically updated to reflect the committed changes.
Closed by commit rG7bb785cc339b: [clangd] Show parameters for construct.
(authored by lh123).
Changed prior to commit:
https://reviews.llvm.org/D114621?vs=391537&id=391542#toc
Repository:
rG LLVM Github Monorepo
CHANG
lh123 updated this revision to Diff 391537.
lh123 marked 3 inline comments as done.
lh123 added a comment.
address comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114621/new/
https://reviews.llvm.org/D114621
Files:
clang-tools-extra/clang
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks LGTM!
let me know if I should land this for you.
Comment at: clang-tools-extra/clangd/Hover.cpp:1054
// editor, as they might be long.
- if (ReturnType) {
+ i
lh123 marked an inline comment as done.
lh123 added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:1065
+ if (Parameters && !Parameters->empty()) {
+Output.addParagraph().appendText("Parameters: ");
kadircet wrote:
> it's a subtle invarian
lh123 updated this revision to Diff 390143.
lh123 added a comment.
address comment.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114621/new/
https://reviews.llvm.org/D114621
Files:
clang-tools-extra/clangd/Hover.cpp
clang-tools-extra/clangd/u
kadircet added inline comments.
Comment at: clang-tools-extra/clangd/Hover.cpp:1065
+ if (Parameters && !Parameters->empty()) {
+Output.addParagraph().appendText("Parameters: ");
it's a subtle invariant that we only have parameters for functions (which has
lh123 created this revision.
lh123 added reviewers: sammccall, kadircet.
lh123 added a project: clang-tools-extra.
Herald added subscribers: usaxena95, arphaman.
lh123 requested review of this revision.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Show parameters for construct.
