[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

chill added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:453 +return "uwtable"; + return ("uwtable(" + Twine(Kind == UWTableKind::Sync ? "sync" : "async") + + ")") RKSimon wrote: > @chill Static analysis is warning that its i

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

RKSimon added inline comments. Comment at: llvm/lib/IR/Attributes.cpp:453 +return "uwtable"; + return ("uwtable(" + Twine(Kind == UWTableKind::Sync ? "sync" : "async") + + ")") @chill Static analysis is warning that its impossible to hi

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

durin42 added a comment. In D114543#3319638 , @chill wrote: > In D114543#3319587 , @durin42 wrote: > >> > > > >> Is the parameter optional if uwtable is set programmatically, or only when >> we're reading IR str

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

chill added a comment. In D114543#3319587 , @durin42 wrote: > > Is the parameter optional if uwtable is set programmatically, or only when > we're reading IR streams? No, it's not optional, the attribute is added by https://github.com/llvm/llvm-pro

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

durin42 added a comment. In D114543#3319576 , @chill wrote: > In D114543#3319347 , @durin42 wrote: > >> As far as I can tell this patch broke the Rust compiler, but from the commit >> message it sounds like it sh

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

chill added a comment. In D114543#3319347 , @durin42 wrote: > As far as I can tell this patch broke the Rust compiler, but from the commit > message it sounds like it shouldn't have? > > https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/bu

[PATCH] D114543: Extend the `uwtable` attribute with unwind table kind

durin42 added a comment. As far as I can tell this patch broke the Rust compiler, but from the commit message it sounds like it shouldn't have? https://buildkite.com/llvm-project/rust-llvm-integrate-prototype/builds/8358#e85ad6f3-9992-4ea1-9cd3-d8db9f45f33e fails with Attribute 'uwtable' sho