[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added a comment. In D114483#3281731 , @aaron.ballman wrote: > In D114483#3281718 , @aaron.ballman > wrote: > >> In D114483#3281714 , @zahiraam >> wrote: >> >>>

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

aaron.ballman added a comment. In D114483#3281718 , @aaron.ballman wrote: > In D114483#3281714 , @zahiraam > wrote: > >> In D114483#3280905 , @MaskRay >> wrote: >> >>>

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

aaron.ballman added a comment. In D114483#3281714 , @zahiraam wrote: > In D114483#3280905 , @MaskRay wrote: > >> Closed by 8ba9c794feb30cd969b9776c39873def10c51bff >>

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added a comment. In D114483#3280905 , @MaskRay wrote: > Closed by 8ba9c794feb30cd969b9776c39873def10c51bff > . > > If the commit message contained `Differential Revision:`, the

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

MaskRay closed this revision. MaskRay added a comment. Closed by 8ba9c794feb30cd969b9776c39873def10c51bff . If the commit message contained `Differential Revision:`, the differential would be closely automatically when you pus

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added a comment. Thanks for the reviews. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listin

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 402900. zahiraam marked 3 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clan

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

Naghasan accepted this revision. Naghasan added a comment. LGTM, thanks for the work CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://li

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

aaron.ballman accepted this revision. aaron.ballman added a comment. LGTM aside from some small nits. Comment at: clang/include/clang/Basic/AttrDocs.td:415 + let Content = [{ +SYCL defines some special classes (accessor, sampler and stream) which require +specific handling dur

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 402850. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clan

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

keryell accepted this revision. keryell added a comment. That looks good. Comment at: clang/include/clang/Basic/AttrDocs.td:459 + SpecialType T; + cgh.single_task([=]() { + T.getF2(); CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 402662. zahiraam marked 4 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clan

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

aaron.ballman added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16686-16687 +if (RD->hasAttr()) { + auto *Def = RD->getDefinition(); + if (Def && !Def->hasInitMethod()) +Diag(RD->getLocation(), zahiraam wrote: > aaron.ballman wr

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam marked 11 inline comments as done. zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:16686-16687 +if (RD->hasAttr()) { + auto *Def = RD->getDefinition(); + if (Def && !Def->hasInitMethod()) +Diag(RD->getLocation(),

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

aaron.ballman added a comment. Thanks! Mostly just minor nits from me. Comment at: clang/include/clang/AST/DeclCXX.h:1143 + void SetInitMethod(bool val) { data().HasInitMethod = val; } + bool hasInitMethod() const { return data().HasInitMethod; } ===

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

bader accepted this revision. bader added a comment. This revision is now accepted and ready to land. LGTM, just one suggestion. It would be great to get @aaron.ballman approve too. Comment at: clang/lib/Sema/SemaDecl.cpp:16690 + diag::err_sycl_special_type_missing_

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added a comment. @Fznamznon @bader @Naghasan reviews please? Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 ___ cfe-commits mailing list cfe-commits@lists.llvm.org https://lists.llv

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9118 + NewFD->getKind() == Decl::Kind::CXXMethod && + NewFD->getName() == "__init" && D.isFunctionDefinition()) { +if (auto *def = Parent->getDefinition()) Fznamznon

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 395176. zahiraam marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clan

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

Fznamznon added inline comments. Comment at: clang/lib/Sema/SemaDecl.cpp:9118 + NewFD->getKind() == Decl::Kind::CXXMethod && + NewFD->getName() == "__init" && D.isFunctionDefinition()) { +if (auto *def = Parent->getDefinition()) In our d

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 393532. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clang/include/clang/Basic/Attr.td clang/inclu

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

zahiraam updated this revision to Diff 393278. zahiraam marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114483/new/ https://reviews.llvm.org/D114483 Files: clang/include/clang/AST/CXXRecordDeclDefinitionBits.def clang/include/clang/AST/DeclCXX.h clan

[PATCH] D114483: [SYCL] Add support for sycl_special_class attribute

Naghasan added a comment. Just a few comments Comment at: clang/include/clang/Basic/AttrDocs.td:411-413 +The ``__attribute__((sycl_special_class))`` attribute is used in SYCL +headers to indicate that a class or a struct needs additional implementation when +it is passed from