[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan added a comment. > but we could pick a couple of esoteric targets where integrals differ > significantly from what we have on x86_64 Turns out `wasm` and `darwin` also have a similar problem, I added them to the skip list for now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan updated this revision to Diff 391120. stevewan added a comment. Herald added subscribers: luke957, s.egerton, simoncook, fedor.sergeev, aheejin. Add targets we are interested in testing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/n

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

steakhal added a comment. In D114454#3162490 , @stevewan wrote: >> setting a bunch of target triples and letting gtest to run each one to see >> if it still passes on all triples. > > Did you mean adding all the triples that we're interested in to > `al

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan added a comment. Finally had some time to get back to this. Thanks @steakhal for your suggestion, the sample code in `ASTMatchersNodeTest.cpp` was helpful. I was actually looking for a good way of querying the target triple as I do agree that it is an better way of fixing this. Hopeful

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan updated this revision to Diff 390795. stevewan added a comment. Herald added a subscriber: mgorny. Pin target triple before analysis Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454 Files: clang

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

jlebar added a comment. > Let me summon them. *I have no memory of this place.* Sorry to disappoint. That blame was four years ago, not counting covid-related time dilation. I do agree that disabling a test just to please a static analyzer is probably not the best way to go. Repository:

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

steakhal added reviewers: jlebar, chandlerc. steakhal added subscribers: jlebar, chandlerc. steakhal added a comment. I think D21810 (commit ) was related to a triple issue in

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

steakhal added a comment. Thanks for fixing this @stevewan! I think disabling a test is worse than actually fixing it, although I can see the frustration it causes. Yet, I would propose something else. This is just a static analyzer checker doing its own thing. What if we were pinning the targ

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

martong edited reviewers, added: steakhal; removed: vsavchenko. martong added a comment. vsavchenko is inactive, presumably he is no longer working with CSA Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114454/new/ https://reviews.llvm.org/D114454

[PATCH] D114454: [NFC][AIX]Disable unstable CSA tests failing on AIX

stevewan created this revision. stevewan requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. CSA uses bitwidth to infer the integer value type. In the ILP32 model, for example 32-bit AIX, any 32-bit integer type will be considerred as `int`, w