[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

melver added a comment. I think we dropped the ball on this - was it ever re-reverted? Is it still worth trying to land this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421 __

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

This revision was automatically updated to reflect the committed changes. Closed by commit rG2b554920f11c: [asan] Add support for disable_sanitizer_instrumentation attribute (authored by glider). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/n

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 393187. glider added a comment. Fix a windows test failure: https://buildkite.com/llvm-project/premerge-checks/builds/69318#0b873cc6-bf07-482a-ac37-e960566ac8a3 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1144

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 393168. glider added a comment. Rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421 Files: clang/docs/AddressSanitizer.rst clang/lib/CodeGen/CodeGenFunction.cp

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider added a comment. > Should we have in AddressSanitizer.cpp the following for consistency with > other sanitizers? Good catch, without that disable_sanitizer_instrumentation could not override sanitize_address. I fixed this and added a test. Comment at: clang/test/CodeG

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 392389. glider added a comment. Updated asan-globals.cpp Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421 Files: clang/docs/AddressSanitizer.rst clang/lib/CodeGen/C

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider updated this revision to Diff 392382. glider added a comment. Herald added subscribers: llvm-commits, hiraditya. Herald added a project: LLVM. Addressed the comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.l

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

vitalybuka accepted this revision. vitalybuka added a comment. Should we have in AddressSanitizer.cpp the following for consistency with other sanitizers? if (F.hasFnAttribute(Attribute::DisableSanitizerInstrumentation)) return false; Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

eugenis accepted this revision. eugenis added a comment. LGTM Comment at: clang/test/CodeGen/asan-globals.cpp:62 // CHECK: ![[ATTR_GLOBAL]] = !{{{.*}}, null, null, i1 false, i1 true} +// CHECK: ![[DISABLE_INSTR_GLOBAL]] = !{{{.*}}, null, null, i1 false, i1 true} // CHECK: ![[

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider added a comment. Given this is a minor change that only affects users of disable_sanitizer_instrumentation, I'm inclined towards landing it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421 ___

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider added a comment. Vitaly, Evgenii, can one of you please take a look? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421 ___ cfe-commits mailing list cfe-com

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

melver accepted this revision. melver added a comment. This revision is now accepted and ready to land. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114421/new/ https://reviews.llvm.org/D114421

[PATCH] D114421: [asan] Add support for disable_sanitizer_instrumentation attribute

glider created this revision. glider added reviewers: melver, vitalybuka. glider requested review of this revision. Herald added a project: clang. Herald added a subscriber: cfe-commits. For ASan this will effectively serve as a synonym for __attribute__((no_sanitize("address"))) Repository: r