[PATCH] D114318: [clang] Add missing CPUID feature bit masks

2021-11-21 Thread Adam Bruce via Phabricator via cfe-commits
adamdb5 updated this revision to Diff 388751. adamdb5 added a comment. Renamed bit_DEPRFPUCSDS to bit_DEPR_FPU_CSDS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114318/new/ https://reviews.llvm.org/D114318 Files: clang/lib/Headers/cpuid.h Inde

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

2021-11-21 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a subscriber: hjl.tools. pengfei added a comment. > bit_HYPERVISOR: This seems to be standardized. See the following links: I'm not sure what are these bits defined according to. From PV of HW, I think this shouldn't be added. This bit is set by hypervisor rather than CPU like oth

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

2021-11-21 Thread Adam Bruce via Phabricator via cfe-commits
adamdb5 updated this revision to Diff 388746. adamdb5 added a comment. Thanks for the feedback, please see the following comments: bit_HYPERVISOR: This seems to be standardized. See the following links: - https://docs.microsoft.com/en-us/virtualization/hyper-v-on-windows/tlfs/feature-discov

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

2021-11-21 Thread Phoebe Wang via Phabricator via cfe-commits
pengfei added a comment. In D114318#3144721 , @adamdb5 wrote: > ran clang-format I think we'd better to keep the existing format. It's in good readability. Comment at: clang/lib/Headers/cpuid.h:110 +#define bit_RDRND 0x4000 +#defi

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

2021-11-21 Thread Adam Bruce via Phabricator via cfe-commits
adamdb5 updated this revision to Diff 388744. adamdb5 added a comment. undo clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114318/new/ https://reviews.llvm.org/D114318 Files: clang/lib/Headers/cpuid.h Index: clang/lib/Headers/cpuid.

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

2021-11-20 Thread Craig Topper via Phabricator via cfe-commits
craig.topper added inline comments. Comment at: clang/lib/Headers/cpuid.h:76 /* Features in %ecx for leaf 1 */ -#define bit_SSE30x0001 -#define bit_PCLMULQDQ 0x0002 -#define bit_PCLMUL bit_PCLMULQDQ /* for gcc compat */ -#define bit_DTES64 0x000

[PATCH] D114318: [clang] Add missing CPUID feature bit masks

2021-11-20 Thread Adam Bruce via Phabricator via cfe-commits
adamdb5 created this revision. Herald added a subscriber: pengfei. adamdb5 retitled this revision from "Whilst working on a project which uses the x86 CPUID instruction, I noticed the header provided by clang (cpuid.h), is missing some bit masks for the feature registers." to "Add missing CPUID b