This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG9f95bc7dc183: [clang][ARM] relax -mtp=cp15 for non-thumb
cases (authored by nickdesaulniers).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE L
peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.
LGTM, thanks for the update.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114116/new/
https://reviews.llvm.org/D114116
_
nickdesaulniers updated this revision to Diff 391396.
nickdesaulniers added a comment.
- update for thumbv6t2, add test for that.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114116/new/
https://reviews.llvm.org/D114116
Files:
clang/lib/Driver/
nickdesaulniers updated this revision to Diff 391390.
nickdesaulniers marked an inline comment as done.
nickdesaulniers added a comment.
- use @peter.smith's suggestion re: ARMV8MBaseline
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114116/new/
ht
peter.smith added a comment.
Apologies, missed a couple of small things out. Otherwise looks good to me.
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:150
+// The backend does not have support for hard thread pointers when targeting
+// Thumb1.
peter.s
peter.smith added a comment.
I've made a suggestion to disallow v8-m.baseline (does not have Thumb 2 but has
number > 7) and to simplify the expression.
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:155
+ llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Triple.getArchName
nickdesaulniers marked 4 inline comments as done.
nickdesaulniers added inline comments.
Comment at: clang/lib/Driver/ToolChains/Arch/ARM.cpp:155
+ llvm::ARM::ArchKind AK = llvm::ARM::parseArch(Triple.getArchName());
+ return Ver >= 7 || AK == llvm::ARM::ArchKind::ARMV6T2 ||
+
nickdesaulniers updated this revision to Diff 391375.
nickdesaulniers retitled this revision from "[clang][ARM] relax -mtp=cp15 for
ARMv6 non-thumb cases" to "[clang][ARM] relax -mtp=cp15 for non-thumb cases".
nickdesaulniers edited the summary of this revision.
nickdesaulniers added a comment.
-
