This revision was automatically updated to reflect the committed changes.
jansvoboda11 marked 2 inline comments as done.
Closed by commit rG197576c40986: [clang][lex] Refactor check for the first file
include (authored by jansvoboda11).
Changed prior to commit:
https://reviews.llvm.org/D114093?
jansvoboda11 marked 3 inline comments as done.
jansvoboda11 added inline comments.
Comment at: clang/include/clang/Lex/HeaderSearch.h:445-447
+ bool ShouldEnterIncludeFile(bool &IsFirstIncludeOfFile, Preprocessor &PP,
+ const FileEntry *File, bool is
vsapsai added a comment.
Have just a few little tweaks, otherwise looks good. And we've discussed that
it's possible we don't really need the first time lexing check anymore. But
that's a separate issue and I support your decision to preserve the existing
behavior and not to increase the scope
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
LGTM with one nit inline.
Comment at: clang/include/clang/Lex/Lexer.h:140-141
+ /// True if this is the first time we're lexing the input file.
+ bool IsFirstTime
jansvoboda11 created this revision.
jansvoboda11 added reviewers: Bigcheese, dexonsmith, vsapsai.
jansvoboda11 requested review of this revision.
Herald added a project: clang.
Herald added a subscriber: cfe-commits.
This patch refactors the code that checks whether a file has just been included
