bmahjour added a comment.
@nemanjai how come the changes in `altivec.h` and
`clang/test/CodeGen/builtins-ppc-p8vector.c` have been removed in the latest
diff and the commit above?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114088/new/
https://
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc933c2eb3346: [PowerPC] Add BCD add/sub/cmp builtins
(authored by nemanjai).
Changed prior to commit:
https://reviews.llvm.org/D114088?vs=387933&id=389238#toc
Repository:
rG LLVM Github Monorepo
CHA
nemanjai added inline comments.
Comment at: clang/lib/Headers/altivec.h:19050
+}
+
+static __inline__ long __bcdcmpeq(vector unsigned char __a,
NeHuang wrote:
> Do we need to add a case for "__CR6_SO_REV"? It is defined in line 25 but not
> used.
I added it for
NeHuang added a comment.
-
Comment at: clang/lib/Headers/altivec.h:19050
+}
+
+static __inline__ long __bcdcmpeq(vector unsigned char __a,
Do we need to add a case for "__CR6_SO_REV"? It is defined in line 25 but not
used.
Comment at: llvm/l
saghir accepted this revision.
saghir added a comment.
This revision is now accepted and ready to land.
LGTM.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114088/new/
https://reviews.llvm.org/D114088
__
nemanjai created this revision.
nemanjai added reviewers: bmahjour, PowerPC.
Herald added subscribers: shchenz, kbarton, hiraditya.
nemanjai requested review of this revision.
Herald added projects: clang, LLVM.
Support for builtins that use `bcdadd./bcdsub.` to add/subtract Binary Coded
Decimal
