[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

thakis added a comment. Thanks for noticing that. It's back and happy now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114077/new/ https://reviews.llvm.org/D114077 ___ cfe-commits mailing list cfe-comm

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall added a comment. In D114077#3218446 , @thakis wrote: > Still broken on windows: http://45.33.8.238/win/51764/step_4.txt I think the builder is stuck, that build is some hours old and doesn't have the fix in it. (Which leaves the possibility th

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

thakis added a comment. Still broken on windows: http://45.33.8.238/win/51764/step_4.txt Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114077/new/ https://reviews.llvm.org/D114077 ___ cfe-commits mailing

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall added a comment. In D114077#3218006 , @thakis wrote: > Breaks building on windows: http://45.33.8.238/win/51774/step_4.txt > > Ptal! Fixed (I think) in a61f34ea2502d900c57a332174d4c103b6963c80

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

thakis added a comment. Breaks building on windows: http://45.33.8.238/win/51774/step_4.txt Ptal! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114077/new/ https://reviews.llvm.org/D114077 ___ cfe-commi

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

This revision was automatically updated to reflect the committed changes. sammccall marked 4 inline comments as done. Closed by commit rG478863ef58c7: [clangd] Basic IncludeCleaner support for c/c++ standard library (authored by sammccall). Changed prior to commit: https://reviews.llvm.org/D114

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

kbobyrev accepted this revision. kbobyrev added a comment. This revision is now accepted and ready to land. LG with a nit, thanks! Comment at: clang-tools-extra/clangd/Headers.h:330 + static inline clang::clangd::stdlib::Header getEmptyKey() { +return clang::clangd::stdlib

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall added inline comments. Comment at: clang-tools-extra/clangd/Headers.h:32 namespace clang { +class NamespaceDecl; namespace clangd { kbobyrev wrote: > Do we need a forward decl here? Decl/NamespaceDecl are needed for the interface of the stdlib symbol

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall updated this revision to Diff 396639. sammccall marked 4 inline comments as done. sammccall added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114077/new/ https://reviews.llvm.org/D114077 Files: clang-tools

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall updated this revision to Diff 396635. sammccall added a comment. (rebase before addressing comments) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114077/new/ https://reviews.llvm.org/D114077 Files: clang-tools-extra/clangd/Headers.cpp

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

kbobyrev added a comment. Mostly LG, few nits. Comment at: clang-tools-extra/clangd/Headers.h:32 namespace clang { +class NamespaceDecl; namespace clangd { Do we need a forward decl here? Comment at: clang-tools-extra/clangd/Headers.h:42 +p

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall added a comment. I can't remember how we discussed this offline, but my plan was to land this and address the limitations as followups rather than extend the scope of this patch. So I think this is ready for review, though certainly not urgent. Repository: rG LLVM Github Monorepo

[PATCH] D114077: [clangd] Basic IncludeCleaner support for c/c++ standard library

sammccall created this revision. sammccall added a reviewer: kbobyrev. Herald added subscribers: usaxena95, kadircet, arphaman. sammccall requested review of this revision. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. Herald added a project: clang-tools-extra. There are some limi