[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

This revision was automatically updated to reflect the committed changes. Closed by commit rGe2cad4df22a6: [clangd] Add ObjC method support to prepareCallHierarchy (authored by sheldonneuberger-sc, committed by kadircet). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

nridge added a comment. In D114058#3150606 , @kadircet wrote: > thanks, lgtm! let me know of your email address (for commit attribution) if > you want me to land this for you. While I don't see it surfaced anywhere in the Phabricator UI, there is in fac

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

kadircet accepted this revision. kadircet added a comment. This revision is now accepted and ready to land. thanks, lgtm! let me know of your email address (for commit attribution) if you want me to land this for you. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://re

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc added a comment. Made suggested changes, ready for another review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 ___ cfe-commits mailing l

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc updated this revision to Diff 389334. sheldonneuberger-sc added a comment. - revert whitespace change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files: clang-tools-extra/clangd/

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

sheldonneuberger-sc updated this revision to Diff 389333. sheldonneuberger-sc added a comment. - inline test helper for readability - fix indentation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114058/new/ https://reviews.llvm.org/D114058 Files:

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

kadircet added inline comments. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:54 +void verifyIncomingMultiFile(std::string SourceExt, std::string HeaderExt, + Annotations &CalleeH, Annotations &Caller1H, nridg

[PATCH] D114058: [clangd] Add ObjC method support to prepareCallHierarchy

nridge added a comment. Thanks, LGTM! I have a couple of nits about the test changes, but with those I think this is good to merged. Comment at: clang-tools-extra/clangd/unittests/CallHierarchyTests.cpp:54 +void verifyIncomingMultiFile(std::string SourceExt, std::string Hea