[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

nridge closed this revision. nridge added a comment. Herald added a project: All. This has been committed in https://github.com/llvm/llvm-project/commit/5a6dac66db67225e2443f4e61dfe9d2f96780611. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

beccadax accepted this revision. beccadax added a comment. This revision is now accepted and ready to land. The diagnostics are now much better—thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://reviews.llvm.org/D114003

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

sammccall added a comment. Added a bit of analysis on https://github.com/clangd/clangd/issues/888. The short version is we built a PCH. When consuming it, the parser decides to re-lex and this means sources must be loaded from disk. These sources are inconsistent with the PCH, so the preconditio

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer updated this revision to Diff 387723. DaanDeMeyer added a comment. Addressed comments by adding two new errors, one for character literals and one for numeric literals. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

beccadax requested changes to this revision. beccadax added a comment. This revision now requires changes to proceed. err_lexing_string’s message is “failure when lexing a string”

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer updated this revision to Diff 387667. DaanDeMeyer added a comment. clang-format Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114003/new/ https://reviews.llvm.org/D114003 Files: clang/lib/Lex/LiteralSupport.cpp Index: clang/lib/Lex

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer added a comment. Added some people that were recent reviewers of changes to this file and some clangd folks. I don't have the time to properly test this unfortunately (aside from verifying that it fixes all the clangd crashes I'm having), but putting the patch up anyway in case any

[PATCH] D114003: LiteralSupport: Don't assert() on invalid input

DaanDeMeyer created this revision. DaanDeMeyer added reviewers: eduucaldas, beccadax, sammccall, kadircet. DaanDeMeyer added a project: clang. Herald added a subscriber: usaxena95. DaanDeMeyer requested review of this revision. Herald added subscribers: cfe-commits, ilya-biryukov. When using cla