[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

kuhnel abandoned this revision. kuhnel added a comment. thx for the explanation, makes sense --> abandoning this change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113902/new/ https://reviews.llvm.org/D113902

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

sammccall added a comment. Details below, but TL;DR is running only on files in `compile_commands.json` is definitely the established way to analyze a project. If you're proposing a *change* then that might be worth considering, but this probably isn't the place: mailing lists are more public an

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

kuhnel added a comment. In D113902#3131707 , @sammccall wrote: > Hmm, clang-tidy should only be running on entries in compile_commands.json. > are these files listed somehow? No, they are not. The question is: Do the tools our contributors use care ab

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

sammccall added a comment. Hmm, clang-tidy should only be running on entries in compile_commands.json. are these files listed somehow? (I don't like the idea that every test inputs dir may need to contain a scattering of files to disable tools. At most we should be able to do this under test/)

[PATCH] D113902: [NFC][clangd] exclude test data from clang-tidy

kuhnel created this revision. Herald added subscribers: usaxena95, kadircet, arphaman. kuhnel added subscribers: sammccall, adamcz, kbobyrev. kuhnel published this revision for review. Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov, aheejin. Herald added a project: clang-tools-extra.