This revision was automatically updated to reflect the committed changes.
Closed by commit rG7aa2ce0fab3c: [NFC][clangd] fix clang-tidy finding on
isa_and_nonnull (authored by kuhnel).
Changed prior to commit:
https://reviews.llvm.org/D113899?vs=387254&id=388127#toc
Repository:
rG LLVM Githu
kadircet accepted this revision.
kadircet added a comment.
This revision is now accepted and ready to land.
thanks!
Comment at: clang-tools-extra/clangd/Selection.cpp:504
bool TraverseDecl(Decl *X) {
-if (X && isa(X))
+if (isa_and_nonnull(X))
return Base::Trav
kuhnel added inline comments.
Comment at: clang-tools-extra/clangd/Selection.cpp:504
bool TraverseDecl(Decl *X) {
-if (X && isa(X))
+if (isa_and_nonnull(X))
return Base::TraverseDecl(X); // Already pushed by constructor.
kadircet wrote:
> while
kuhnel created this revision.
Herald added subscribers: carlosgalvezp, usaxena95, kadircet, arphaman.
kuhnel added subscribers: sammccall, kbobyrev, adamcz.
kadircet added inline comments.
kuhnel published this revision for review.
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov.
Hera
