[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

carlosgalvezp updated this revision to Diff 387519. carlosgalvezp marked 4 inline comments as done. carlosgalvezp added a comment. - Rebased. - Addressed comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113848/new/ https://reviews.llvm.org/D113848 Files: clang-tools-extra/clan

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

carlosgalvezp added a comment. > What is the motivation behind the change? The motivation is cleaning the file to make it easier to find things. As a n00b to clang-tidy I find it a bit hard to navigate the code and find the different classes - they are not where I expect them to be. The `ClangT

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

whisperity added a comment. What is the motivation behind the change? Can we be sure that these classes that were moved out weren't details to the context itself, and are understandable, usable, and can be relied upon without the context object? In D113848#3130542

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

carlosgalvezp added a comment. I agree with the comments, but I didn't want to touch any code other than moving things around, since it's hard to see the changes in the diff otherwise. I was also unsure if this was "LLVM convention" or a mistake. I'm happy to fix in a separate patch if that's O

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

Eugene.Zelenko added inline comments. Comment at: clang-tools-extra/clang-tidy/ClangTidyContext.cpp:40 +#include +using namespace clang; +using namespace tidy; Shouldn't namespaces be used instead? Comment at: clang-tools-extra/clang-tidy/Clan

[PATCH] D113848: [clang-tidy][NFC] Refactor ClangTidyDiagnosticConsumer files

carlosgalvezp created this revision. carlosgalvezp added reviewers: aaron.ballman, whisperity. Herald added subscribers: rnkovacs, xazax.hun, mgorny. carlosgalvezp requested review of this revision. Herald added a project: clang-tools-extra. Herald added a subscriber: cfe-commits. Currently, Clang